Skip to content

Disable six StyleCop rules in shared C# conventions - #81

Closed
JasonETucker wants to merge 3 commits into
masterfrom
disable-selected-stylecop-rules
Closed

JasonETucker wants to merge 3 commits into
masterfrom
disable-selected-stylecop-rules

Conversation

@JasonETucker

@JasonETucker JasonETucker commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Disable SA1111, SA1143, SA1315, SA1413, SA1500, and SA1653 in the shared C# editorconfig policy.

Failing builds:

JasonETucker and others added 3 commits October 19, 2026 18:11
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ejball

ejball commented Oct 20, 2026

Copy link
Copy Markdown
Member

I at least had #79 ready to go but @bgrainger held me back. :-)

@bgrainger

Copy link
Copy Markdown
Member

We should just fix these warnings instead?

@bgrainger

Copy link
Copy Markdown
Member

Hopefully the newest StyleCop.Analyzers has my fix: DotNetAnalyzers/StyleCopAnalyzers#4336

@bgrainger

bgrainger commented Oct 20, 2026 •

Copy link
Copy Markdown
Member
  • ✅ FaithlifeAnalyzers
  • ✅ FaithlifeReflection
  • ✅ FaithlifeBuild fixed
  • ✅ FaithlifeTesting

@bgrainger

Copy link
Copy Markdown
Member

We'll fix the code instead.

@bgrainger bgrainger closed this Oct 20, 2026
@JasonETucker

Copy link
Copy Markdown
Contributor Author

@bgrainger thanks Bradly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants