test(retention): isolate audit failure fixtures - #75
Merged
Merged
Conversation
TusanHomichi
marked this pull request as ready for review
September 23, 2026 15:59
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary Issue
Refs #70. This existing CI failure blocks the authorized workflow correction in #73 / #74.
Problem And Outcome
The combined retention audit-failure test drops and recreates a trigger through a connection pool. With the repository-pinned SQLite, a connection holding an older schema view can reject the second CREATE even after another connection successfully dropped the trigger. Separate the authority and policy scenarios into fresh fixtures so each installs its trigger once. Every original product call and rollback assertion is retained.
Only
crates/consolebook-server/tests/retention.rschanges. No runtime, migrations, dependencies, pool behavior, retry logic or required gates change.Verification
Frozen candidate
0e2a21aecd216520f7b6b07154eb63adb3c77431, tree332ad374d6dc12104f0ae4a30c02629df7d53086.PASS: formatting, whitespace, parent diff review; a SQLx 0.8.6 / SQLite 3.46.0 diagnostic reproduces the exact error on a stale connection while a fresh one observes the trigger absent and successfully recreates it. The parent independently compiled the C probe against the pinned SQLite and verified the same observations. This proves the mechanism, not the full failed hosted run's connection assignment.
PASS: all nine required local gates, 176 Rust tests and 10 browser tests. All receipts record the frozen revision, clean worktree state and verified output hashes. Independent Astra/max model review found no substantive findings.
PASS: hosted gate 35885138099, including 176 Rust tests and 10 browser tests. Local receipts and independent review were read back from the issue; hosted logs are archived separately. The original failed run on #74 remains preserved.
Review And Merge Notes
Sol/max investigated and implemented the fixture-only repair; Astra/max reviews and integrates it as the direct prerequisite for the already authorized policy-correction merge. Luna/max executes local checks. No broader product or deployment authority is inferred. The canonical dependency graph is in #73.