Repository navigation
fix(music): searched songs start a radio, removed songs skip at once - #1287
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/playerrequests while the spinner showed.EventLogger(tagMusicPlayerEvents) for logcat, and the diagnostics report now records each lookup's client and time, the selected audio format or a missing audio track, audio sink and codec errors, and buffering that lasts more than 20 seconds.Related issue
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(3751 tests, 0 failures):app:compileFossDebugKotlin,spotlessCheck)Device checks: searching "Loser" and tapping a result in the Songs tab queued that song plus 10 radio tracks by different artists. A removed song (
_8DXhtXXTVg) was skipped 3.5 s after the tap with a single lookup and the message shown, and the next song played.Test device and Android version: POCO X6 Pro (2311DRK48G), HyperOS, Android 16
Screenshots or recordings
Risk and compatibility
Music search no longer passes the result list as the queue; album, playlist, artist and home playback are unchanged. Removed songs make far fewer network requests. A stream lookup that runs past 30 seconds now fails and goes through the service's existing retries.