Skip to content

fix(music): searched songs start a radio, removed songs skip at once - #1287

Merged
A-EDev merged 3 commits into
mainfrom
fix/music-search-queue-and-unavailable
Oct 11, 2026
Merged

A-EDev merged 3 commits into
mainfrom
fix/music-search-queue-and-unavailable

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Tapping a song in music search (phone and TV) now queues only that song. Endless radio is seeded from it and fills Up Next with related songs straight away, as in YouTube Music, instead of queueing the other results for the same title.
  • A song removed from YouTube (unavailable on every client) is now skipped after one lookup with "This song is no longer available on YouTube." Before, Media3 and the service retried it for about 4.5 minutes and about 195 /player requests while the spinner showed.
  • Finding a song's stream is capped at 30 seconds, the same budget as the video player, so a stuck lookup becomes an error instead of an endless spinner. Neither case is retried by the loader.
  • Music playback logging: Media3 EventLogger (tag MusicPlayerEvents) for logcat, and the diagnostics report now records each lookup's client and time, the selected audio format or a missing audio track, audio sink and codec errors, and buffering that lasts more than 20 seconds.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (3751 tests, 0 failures)
  • I ran any additional flavor-specific build or test tasks affected by this change. (:app:compileFossDebugKotlin, spotlessCheck)
  • I manually tested the affected behavior on an Android device or emulator.

Device checks: searching "Loser" and tapping a result in the Songs tab queued that song plus 10 radio tracks by different artists. A removed song (_8DXhtXXTVg) was skipped 3.5 s after the tap with a single lookup and the message shown, and the next song played.

Test device and Android version: POCO X6 Pro (2311DRK48G), HyperOS, Android 16

Screenshots or recordings

Risk and compatibility

Music search no longer passes the result list as the queue; album, playlist, artist and home playback are unchanged. Removed songs make far fewer network requests. A stream lookup that runs past 30 seconds now fails and goes through the service's existing retries.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings October 11, 2026 18:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added player Video and audio playback ui Compose UI, theming, or Material 3 surfaces labels Oct 11, 2026
@A-EDev
A-EDev merged commit 16ccbfd into main Oct 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

player Video and audio playback ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants