Repository navigation
Treat a missing SAML group claim as no groups when other teams are allowed - #9028
Open
shubhamkapoor01 wants to merge 2 commits into
Open
shubhamkapoor01 wants to merge 2 commits into
shubhamkapoor01 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the IdP omits the group claim (Azure does this when the user is in no groups), login failed with "SAML response missing ... assertion". When "allow users to be in other teams" is on, it's now logged and treated as an empty list, so the user can still log in. Without that option it still fails as before.
An empty list follows the existing behaviour for an empty group claim, so with
groupAdminset it also clears the admin flag (unless they're the last admin, which the existing guard keeps). There's a test for that too. Happy to change it if you'd rather keep admin in this case (see my question on the issue).Related Issue(s)
Fixes #6528
Checklist
flowforge.yml?