fix(ping-sdk): fix import order for all files in ping sdk by vatsalparikh · Pull Request #683 · ForgeRock/ping-javascript-sdk

vatsalparikh · 2026-06-09T17:11:04Z

Merge after 2.2 release of Ping SDK

Summary

Adds `eslint-plugin-simple-import-sort` to enforce consistent import ordering across all packages
Adds `@typescript-eslint/consistent-type-imports` to enforce separate `import type` statements
Adds `import/consistent-type-specifier-style` to split mixed value/type imports into separate declarations
Fixes pre-existing inline `import()` type annotation violations in `oidc-client` and `davinci-client`
Fixes `@nx/dependency-checks` in `journey-client` incorrectly adding test-only deps to `dependencies` during `--fix` runs
Preserves Effect Schema declaration-merging `interface` pattern in `mock-api-v2` schemas (protected by existing local ESLint config)

Test plan

`pnpm nx affected -t lint` passes with no errors
`pnpm nx affected -t typecheck` passes with no errors
`pnpm nx affected -t build` passes with no errors
CI passes end-to-end

changeset-bot · 2026-06-09T17:11:09Z

⚠️ No Changeset found

Latest commit: 42caeef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-06-09T17:11:12Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cf25459e-4b62-4da1-8356-2c127f5292db

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-import-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-06-25T00:51:22Z

View your CI Pipeline Execution ↗ for commit 42caeef

Command	Status	Duration	Result
`nx run-many -t build --no-agents`	✅ Succeeded	<1s	View ↗
`nx affected -t build lint test typecheck e2e-ci`	✅ Succeeded	1m 38s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-09-08 17:22:07 UTC

pkg-pr-new · 2026-06-25T00:55:18Z

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@683

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@683

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@683

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@683

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@683

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@683

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@683

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@683

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@683

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@683

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@683

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@683

commit: 42caeef

codecov-commenter · 2026-06-25T00:55:46Z

Codecov Report

❌ Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 24.11%. Comparing base (eafe277) to head (42caeef).
⚠️ Report is 127 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/protect/src/lib/signals-sdk.js	0.00%	1 Missing ⚠️

❌ Your project status has failed because the head coverage (24.11%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   18.07%   24.11%   +6.03%     
==========================================
  Files         155      163       +8     
  Lines       24398    25797    +1399     
  Branches     1203     1687     +484     
==========================================
+ Hits         4410     6221    +1811     
+ Misses      19988    19576     -412

Files with missing lines	Coverage Δ
...ges/davinci-client/src/lib/client.store.effects.ts	`49.73% <100.00%> (ø)`
packages/davinci-client/src/lib/client.store.ts	`25.20% <100.00%> (+24.91%)`	⬆️
...kages/davinci-client/src/lib/client.store.utils.ts	`66.46% <100.00%> (+42.73%)`	⬆️
packages/davinci-client/src/lib/client.types.ts	`100.00% <ø> (ø)`
packages/davinci-client/src/lib/collector.types.ts	`100.00% <ø> (ø)`
packages/davinci-client/src/lib/collector.utils.ts	`87.13% <ø> (+1.98%)`	⬆️
packages/davinci-client/src/lib/config.slice.ts	`100.00% <100.00%> (ø)`
packages/davinci-client/src/lib/davinci.api.ts	`27.85% <100.00%> (+15.88%)`	⬆️
packages/davinci-client/src/lib/davinci.types.ts	`100.00% <ø> (ø)`
packages/davinci-client/src/lib/davinci.utils.ts	`85.48% <ø> (-4.46%)`	⬇️
... and 92 more

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-06-25T00:55:54Z

Deployed ff603ab to https://ForgeRock.github.io/ping-javascript-sdk/pr-683/ff603abf704cc5aae8e799b7637ebbcb9df9563e branch gh-pages in ForgeRock/ping-javascript-sdk

github-actions · 2026-06-25T00:56:06Z

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/device-client - 0.0 KB (new)
🆕 @forgerock/device-client - 10.3 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)
🆕 @forgerock/journey-client - 92.9 KB (new)

📊 Minor Changes

📉 @forgerock/recognize - 4284.4 KB (-0.0 KB)
📈 @forgerock/oidc-client - 36.0 KB (+0.5 KB)
📈 @forgerock/storage - 1.5 KB (+0.0 KB)
📉 @forgerock/iframe-manager - 3.2 KB (-0.0 KB)
📈 @forgerock/sdk-logger - 1.6 KB (+0.0 KB)
📈 @forgerock/sdk-oidc - 5.8 KB (+0.0 KB)
📈 @forgerock/sdk-request-middleware - 4.6 KB (+0.0 KB)
📈 @forgerock/sdk-utilities - 18.8 KB (+0.0 KB)
📉 @forgerock/protect - 144.6 KB (-0.0 KB)
📈 @forgerock/davinci-client - 59.7 KB (+0.1 KB)

➖ No Changes

➖ @forgerock/sdk-types - 9.1 KB

15 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated

Current Size: Total gzipped size of all files in the package's dist directory
Baseline: Comparison against the latest build from the main branch
Files included: All build outputs except source maps and TypeScript build cache
Exclusions: .map, .tsbuildinfo, and .d.ts.map files

_{🔄 Updated automatically on each push to this PR}

SteinGabriel

Other than 2 stale and 1 missing copyright header, these changes look good to merge.

Stale:

e2e/davinci-suites/playwright.config.ts
e2e/journey-suites/playwright.config.ts

Missing:

e2e/oidc-suites/playwright.config.ts

vatsalparikh · 2026-09-08T17:20:11Z

Other than 2 stale and 1 missing copyright header, these changes look good to merge.

Stale:

e2e/davinci-suites/playwright.config.ts

e2e/journey-suites/playwright.config.ts

Missing:

e2e/oidc-suites/playwright.config.ts

Thanks, updated / created copyright header for these files!

vatsalparikh mentioned this pull request Jun 9, 2026

Sdks 5097 #670

Merged

vatsalparikh force-pushed the fix-import-order branch from 0cd4647 to 2fac585 Compare June 25, 2026 00:50

vatsalparikh marked this pull request as ready for review June 25, 2026 00:56

vatsalparikh requested review from SteinGabriel, ancheetah, cerebrl and ryanbas21 June 25, 2026 00:56

SteinGabriel requested changes Jul 3, 2026

View reviewed changes

Comment thread packages/device-client/src/lib/device.store.utils.ts

Comment thread e2e/oidc-suites/src/utils/login.ts Outdated

vatsalparikh force-pushed the fix-import-order branch from 7ed91f4 to 921ba93 Compare September 8, 2026 14:15

chore: fix import order and normalize copyright headers

46c18c1

vatsalparikh force-pushed the fix-import-order branch from 921ba93 to 46c18c1 Compare September 8, 2026 14:56

SteinGabriel approved these changes Sep 8, 2026

View reviewed changes

vatsalparikh added the do not merge label Sep 8, 2026

chore: fix copyright headers per review feedback

42caeef

vatsalparikh mentioned this pull request Sep 8, 2026

chore(security): bump fast-uri, undici, vitest to fix CVEs #815

Draft

Navigation Menu

Uh oh!

fix(ping-sdk): fix import order for all files in ping sdk - #683

fix(ping-sdk): fix import order for all files in ping sdk#683
vatsalparikh wants to merge 2 commits into
mainfrom
fix-import-order

vatsalparikh commented Jun 9, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Jun 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

SteinGabriel left a comment

Uh oh!

vatsalparikh commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

vatsalparikh commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

changeset-bot Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

Legend

Uh oh!

Uh oh!

Uh oh!

SteinGabriel left a comment

Choose a reason for hiding this comment

Uh oh!

vatsalparikh commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

vatsalparikh commented Jun 9, 2026 •

edited

Loading

changeset-bot Bot commented Jun 9, 2026 •

edited

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

nx-cloud Bot commented Jun 25, 2026 •

edited

Loading

pkg-pr-new Bot commented Jun 25, 2026 •

edited

Loading

codecov-commenter commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading