Skip to content

feat: add AM mediation check to WebAuthn and export storage config types - #762

Open
vatsalparikh wants to merge 1 commit into
mainfrom
feat/storage-export-webauthn-mediation
Open

feat: add AM mediation check to WebAuthn and export storage config types#762
vatsalparikh wants to merge 1 commit into
mainfrom
feat/storage-export-webauthn-mediation

Conversation

@vatsalparikh

@vatsalparikh vatsalparikh commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Merge after 2.2 release

JIRA ticket

https://pingidentity.atlassian.net/browse/SDKS-5367

Summary

  • WebAuthn.isConditionalMediationSupported now optionally accepts a JourneyStep and, when provided, also checks that AM requested conditional mediation via the WebAuthn metadata (meta.mediation === 'conditional')
  • Export BrowserStorageConfig, CustomStorageConfig from @forgerock/storage and CustomStorageObject from @forgerock/sdk-types off oidc-client's types entry point

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fe6f90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@forgerock/journey-client Minor
@forgerock/oidc-client Minor
@forgerock/davinci-client Minor
@forgerock/device-client Minor
@forgerock/protect Minor
@forgerock/recognize Minor
@forgerock/sdk-types Minor
@forgerock/sdk-utilities Minor
@forgerock/iframe-manager Minor
@forgerock/sdk-logger Minor
@forgerock/sdk-oidc Minor
@forgerock/sdk-request-middleware Minor
@forgerock/storage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud

nx-cloud Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 8fe6f90

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded <1s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded 4m 2s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-01 16:22:19 UTC

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 88493102-0e74-4d88-9ce5-846168d1cefa


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@762

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@762

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@762

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@762

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@762

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@762

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@762

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@762

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@762

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@762

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@762

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@762

commit: 8fe6f90

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.14%. Comparing base (eafe277) to head (8fe6f90).
⚠️ Report is 116 commits behind head on main.

❌ Your project status has failed because the head coverage (24.14%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
+ Coverage   18.07%   24.14%   +6.07%     
==========================================
  Files         155      163       +8     
  Lines       24398    25802    +1404     
  Branches     1203     1691     +488     
==========================================
+ Hits         4410     6231    +1821     
+ Misses      19988    19571     -417     
Files with missing lines Coverage Δ
...ckages/journey-client/src/lib/webauthn/webauthn.ts 18.57% <100.00%> (+2.87%) ⬆️
packages/oidc-client/src/types.ts 12.50% <100.00%> (-1.79%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Deployed d6f3689 to https://ForgeRock.github.io/ping-javascript-sdk/pr-762/d6f368962cefec6c7df34464b8fafa276e508c31 branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/journey-client - 92.9 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)
🆕 @forgerock/device-client - 10.0 KB (new)
🆕 @forgerock/device-client - 0.0 KB (new)

📊 Minor Changes

📈 @forgerock/oidc-client - 35.5 KB (+0.0 KB)

➖ No Changes

@forgerock/sdk-utilities - 18.6 KB
@forgerock/recognize - 4284.4 KB
@forgerock/sdk-request-middleware - 4.6 KB
@forgerock/iframe-manager - 3.2 KB
@forgerock/sdk-oidc - 5.7 KB
@forgerock/storage - 1.5 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/sdk-types - 9.1 KB
@forgerock/davinci-client - 59.7 KB
@forgerock/protect - 144.6 KB


15 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants