feat: add AM mediation check to WebAuthn and export storage config types - #762
feat: add AM mediation check to WebAuthn and export storage config types#762vatsalparikh wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 8fe6f90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 8fe6f90
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (24.14%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 18.07% 24.14% +6.07%
==========================================
Files 155 163 +8
Lines 24398 25802 +1404
Branches 1203 1691 +488
==========================================
+ Hits 4410 6231 +1821
+ Misses 19988 19571 -417
🚀 New features to boost your workflow:
|
|
Deployed d6f3689 to https://ForgeRock.github.io/ping-javascript-sdk/pr-762/d6f368962cefec6c7df34464b8fafa276e508c31 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/journey-client - 92.9 KB (new) 📊 Minor Changes📈 @forgerock/oidc-client - 35.5 KB (+0.0 KB) ➖ No Changes➖ @forgerock/sdk-utilities - 18.6 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
Merge after 2.2 release
JIRA ticket
https://pingidentity.atlassian.net/browse/SDKS-5367
Summary
WebAuthn.isConditionalMediationSupportednow optionally accepts aJourneyStepand, when provided, also checks that AM requested conditional mediation via the WebAuthn metadata (meta.mediation === 'conditional')BrowserStorageConfig,CustomStorageConfigfrom@forgerock/storageandCustomStorageObjectfrom@forgerock/sdk-typesoffoidc-client's types entry point