feat(rn-oidc): add device authorization grant support (SDKS-5166) - #69
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 104 files, which is 4 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (104)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (45.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
============================================
- Coverage 73.09% 71.39% -1.70%
- Complexity 261 265 +4
============================================
Files 167 180 +13
Lines 21637 23275 +1638
Branches 779 1027 +248
============================================
+ Hits 15816 16618 +802
- Misses 5732 6502 +770
- Partials 89 155 +66
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
|
tsdamas
reviewed
Sep 3, 2026
tsdamas
reviewed
Sep 3, 2026
rodrigoareis
requested changes
Sep 3, 2026
rodrigoareis
left a comment
rodrigoareis
left a comment
Contributor
There was a problem hiding this comment.
Overall changes looks good. Left comments
tsdamas
reviewed
Sep 3, 2026
tsdamas
reviewed
Sep 3, 2026
Contributor
|
PR reviewed. Left some comments. |
Restore displaced createWebClient KDoc/annotation in Android modules; add KDoc to new device APIs (Android modules, iOS Common/Impl). Swap Android device registry to SimpleRegistry. Verify deviceClientId ownership before cancelling flows on both platforms (iOS DeviceTaskStore owner map with atomic remove(ownedBy:) and cancelAll(for:)). Cancel owned tasks before registry removal on iOS dispose. Document nextPollAt epoch-ms unit contract. Map all 10 missing config fields in RNPingOidc.mm createOidcDeviceClient for TurboModule parity. Wire deviceAuthorizationEndpoint end-to-end through core OidcOpenIdConfig, OIDC handles, and Journey parser/override paths. Restore README sections replaced by device-grant docs. Add Detox E2E for the device-flow scenario (expired/accessDenied/failure).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ping-identity/rn-oidc:createOidcDeviceClient,useDeviceAuthGranthook withDeviceAuthGrantProvider, and the newdeviceOpenVerificationUrl/openVerificationUrlAPI for on-device browser approvalopenIdendpoint overrides (notablydeviceAuthorizationEndpointfor Advanced Identity Cloud) with merge-onto-discovery semantics in rn-oidc, rn-journey, and rn-coreTest plan
yarn workspace @ping-identity/rn-oidc test- 48/48 (facade, hook, client-swap, openVerificationUrl tests):ping-identity_rn-oidc:compileDebugKotlin- clean rebuildChangesets
device-auth-grant-hook,oidc-partial-openid-override-and-cancel-fix,oidc-openid-config-optional-fields,journey-partial-openid-override,core-openid-config-optional-fields,journey-verification-uri,davinci-verification-uri,device-open-verification-url🤖 Generated with Claude Code