Conversation
With configNUMBER_OF_CORES > 1, = { pdFALSE } only names the first
element and leaves the rest implicitly zero (Rule 9.3). Use = { 0 }
like the MPU object pool fix in FreeRTOS#973. Same value: pdFALSE is 0.
Fixes FreeRTOS#1491
Signed-off-by: 20000419 <lzy20000419@outlook.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
configNUMBER_OF_CORES > 1,tasks.cinitializesxYieldPendings[ configNUMBER_OF_CORES ]as{ pdFALSE }. Only thefirst element is named, which breaks MISRA C:2012 Rule 9.3 (arrays
shall not be partially initialized).
Switch the initializer to
{ 0 }, same pattern as the MPU object-poolfix in #973.
pdFALSEis((BaseType_t) 0)inprojdefs.h, so everycore still starts clear — no behavior change.
Test Steps
Confirm the initializer in
tasks.cand thatpdFALSEis 0 inprojdefs.h. Startup on an SMP build is enough to show the array isstill usable.
Checklist:
Related Issue
Fixes #1491
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.