Skip to content

👷 ci: don't cancel CI runs on main - #41

Merged
nstarman merged 3 commits into
GalacticDynamics:mainfrom
nstarman:ci/no-cancel-on-main
Oct 10, 2026
Merged

nstarman merged 3 commits into
GalacticDynamics:mainfrom
nstarman:ci/no-cancel-on-main

Conversation

@nstarman

Copy link
Copy Markdown
Contributor

Pushes to main shared a single concurrency group per workflow with cancel-in-progress: true, so each merge cancelled the run for the merge before it, leaving gaps in main's CI history. Setting cancel-in-progress: false alone wouldn't fix it, because GitHub keeps only one pending run per group and drops the rest.

This adds the commit SHA to the group for pushes to main, so every merged commit gets a complete run. PRs, tags and releases keep their per-ref groups, so a new push to a PR still cancels that PR's older run.

Files: .github/workflows/cd.yml, .github/workflows/ci.yml

🤖 Generated with Claude Code

Give each push to main its own concurrency group (keyed on the SHA) so
every merged commit gets a complete CI record. PRs, tags and releases
keep their per-ref groups and still supersede older runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@f9da872). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #41   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        16           
  Branches        ?         0           
========================================
  Hits            ?        16           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nstarman and others added 2 commits October 10, 2026 17:24
Append the SHA only for push events (which only fire on main), so PRs,
releases and manual runs keep their exact previous group names with no
trailing '-'. Use an explicit folded scalar (>-) so the wrapped
expression reads unambiguously as one string.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Not every workflow runs on releases or manual triggers; say "all other
events" so the comment stays accurate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nstarman nstarman added this to the v0.2.0 milestone Oct 10, 2026
@nstarman
nstarman merged commit 8acaf6b into GalacticDynamics:main Oct 10, 2026
15 checks passed
@nstarman
nstarman deleted the ci/no-cancel-on-main branch October 10, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant