Repository navigation
feat(bridging-widget): implement GoodWidget bridging widget (#243) - #251
Open
goodbounties-nanoclaw-agent[bot] wants to merge 82 commits into
Open
goodbounties-nanoclaw-agent[bot] wants to merge 82 commits into
goodbounties-nanoclaw-agent[bot] wants to merge 82 commits into
Conversation
examples/storybook/package.json On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
examples/storybook/src/stories/bridging-widget/BridgingWidgetQA.stories.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
examples/storybook/src/stories/helpers/bridgingWidgetStories.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/package.json On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/BridgingWidget.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/adapter.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/adapter/bridgeRoutes.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…t Bridge tab packages/bridging-widget/src/adapter/bridgingClient.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/adapter/chains.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…t Bridge tab packages/bridging-widget/src/adapter/errors.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…steps 5+6) packages/bridging-widget/src/adapter/submissionSteps.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…t Bridge tab packages/bridging-widget/src/adapter/useBridgeConfig.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…(step 7) packages/bridging-widget/src/adapter/useBridgeHistory.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…t Bridge tab packages/bridging-widget/src/adapter/useBridgeQuote.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…steps 5+6) packages/bridging-widget/src/adapter/useBridgeSubmission.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…t Bridge tab packages/bridging-widget/src/amount.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…t Bridge tab packages/bridging-widget/src/components/AmountEntry.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…steps 5+6) packages/bridging-widget/src/components/BridgeConfirmModal.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…(step 7) packages/bridging-widget/src/components/BridgeHistoryDetailModal.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/components/BridgeTab.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/components/BridgingWidgetView.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/components/FaqTab.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…t Bridge tab packages/bridging-widget/src/components/FeeBreakdown.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/components/HistoryTab.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…steps 5+6) packages/bridging-widget/src/components/ReviewScreen.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/components/WalletGate.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/components/shared.tsx On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/element.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
packages/bridging-widget/src/faqContent.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…, route/protocol selection packages/bridging-widget/src/index.ts On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…per-entry failure handling, polling, partial-fetch UI) Trims PR #251 round-1 to the 4 approved History-side fixes: - group history entries by bridge+source chain+id (ids are only unique per chain) - Promise.allSettled per entry so one failed delivery-status lookup doesn't blank the whole list - poll while any entry is pending, refresh on submission completion - surface partial-fetch failures in the History tab UI with a Retry/Refresh affordance On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
…per-entry failure handling, polling, partial-fetch UI) Trims PR #251 round-1 to the 4 approved History-side fixes: - group history entries by bridge+source chain+id (ids are only unique per chain) - Promise.allSettled per entry so one failed delivery-status lookup doesn't blank the whole list - poll while any entry is pending, refresh on submission completion - surface partial-fetch failures in the History tab UI with a Retry/Refresh affordance On-Behalf-Of: BountyCoder[onecli] (yaskkeryodtdijpv)
11 tasks
11 tasks done
…43-bridging-widget
…43-bridging-widget
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the approved execution plan from #244 for #243: a new
@goodwidget/bridging-widgetpackage wrapping@goodsdks/bridging-sdk, covering wallet gate → chain/protocol selection → amount entry/fee quote → review → confirm/submit → history → FAQ, plus Storybook QA fixtures and a Playwright spec with baseline screenshots per repo convention.What's included
packages/bridging-widget: adapter hook (useBridgingAdapter) + presentational components for all widget states (loading, error, below-min-amount, insufficient-balance, needs-approval, ready-to-bridge, review, submission steps, history, FAQ).examples/storybook:QA/BridgingWidget/Runtime Fixturesstories exercising every adapter state via local fixtures, plus a custodial-local and injected-wallet live story.tests/widgets/bridging-widget/states.spec.ts+ baseline screenshots (bw-01…bw-26), run against the fixtures above.Manual QA performed
pnpm --filter @goodwidget/bridging-widget build— clean (tsup ESM/CJS/DTS; this is the package's real type-check gate, sincetsconfig.jsonisn't meant for standalonetsc --noEmit).pnpm --filter @goodwidget/bridging-widget lint— clean.pnpm --filter @goodwidget/storybook build-storybook— clean, widget fixtures bundled.pnpm exec tsc --noEmit -p tsconfig.jsoninexamples/storybook— 3 pre-existing errors surfaced (DataTable.stories.tsxx2,GoodReserveWidget.stories.tsx, a Tamagui vendor type) — confirmed viagit diff --stat origin/main..HEADto be untouched by this branch, not introduced here.pnpm exec playwright test tests/widgets/bridging-widget/states.spec.ts— 18/18 passed against a live Storybook server.Notes for reviewers
Inputcomponent typing gap — surfaced while wiringAmountEntry; not fixed here as it's out of this widget's scope, flagging for a follow-up.@goodsdks/bridging-sdkv1.0.6 gap-resolution status — the plan's Risks section called out gaps against the SDK version pinned at plan time; confirm currentpnpm-lock.yamlpin still matches what was validated during planning.@goodsdks/react-hooksabsence — the plan referenced this package as a possible dependency; it isn't present in the monorepo, so the adapter hook talks to@goodsdks/bridging-sdkdirectly instead.faqBridgeCopy(notfaqMpbBridgeCopy) forFaqTab; flagging the choice explicitly since both exist in the content package.@goodwidget/bridging-widgetre-exportsBridgeConfig/BridgeFeeQuote/BridgeProtocol/BridgeRequirement/BridgeTransactionfrom@goodsdks/bridging-sdkso Storybook fixtures can build adapter state without a direct SDK dependency — same pattern used elsewhere in the repo.fullPage: truecaptures of the Review/Confirm/Submission modals show a cosmetic "ghosting" duplication from Playwright's screenshot-stitching when aposition: fixedoverlay spans multiple viewport segments. Confirmed identical in freshly-regenerated captures vs. the committed baselines — a known Playwright capture quirk, not a widget rendering bug, so no code change was made for it.Acceptance criteria