Repository navigation
fix: keep helm deploy job pods from being evicted by cluster-autoscaler - #275
Merged
Merged
Conversation
vigneshrajsb
force-pushed
the
fix/helm-deploy-job-safe-to-evict
branch
from
October 27, 2026 22:55
24582c8 to
4da17ab
Compare
vigneshrajsb
marked this pull request as ready for review
October 27, 2026 23:11
binlab
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cluster-autoscaler.kubernetes.io/safe-to-evict: "false", matching what native build jobs already set.helm upgrade. WithbackoffLimit: 0, that fails the deploy even though nothing was wrong with the service.Verifying Changes
kubernetes/jobFactory.createHelmJob(the factory used for helm deploys).jestforkubernetes,nativeHelm,nativeBuildandeslintpass.