Skip to content

Added functionality for multiple equal tabs. Regarding Issue #2238 - #2317

Open
lucasperez-techdev wants to merge 1 commit into
Guake:masterfrom
lucasperez-techdev:master
Open

Added functionality for multiple equal tabs. Regarding Issue #2238#2317
lucasperez-techdev wants to merge 1 commit into
Guake:masterfrom
lucasperez-techdev:master

Conversation

@lucasperez-techdev

Copy link
Copy Markdown

#2238
Please review my code changes for this issue. Added 2 new arguments, --split-vertical-tabs and --split-vertical-tabs. Both of these arguments take in a value from 2 and greater and splits the terminal selected into an N number of equally split terminals.

…split-vertical-tabs and --split-horizontal-tabs
@Davidy22

Copy link
Copy Markdown
Collaborator

The change seems good, but the name had me under the impression that this did something with the things that are already called tabs. Can the name not be panels or something? Also, a release note file should be made for this, do a make reno slug and fill the file in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants