Skip to content

bug fix _rib_assingn - #158

Open
TanjaLe wants to merge 3 commits into
mainfrom
tanja
Open

TanjaLe wants to merge 3 commits into
mainfrom
tanja

Conversation

@TanjaLe

@TanjaLe TanjaLe commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@TanjaLe TanjaLe self-assigned this Sep 30, 2026
@TanjaLe
TanjaLe requested a review from robert-graf September 30, 2026 08:21
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Benchmark comparison

Speed (wall time per call)

baseline 974263a vs head 974263a · python 3.11.16 · 5 repeats + 1 warmup

Showing the 5 most-changed measurements per case; the rest are collapsed. Rows with a baseline below 3 ms are tagged (noise) — runner jitter on those swamps any real change.

ct_3d — shape (73, 47, 73)

Measurement baseline ms (median ±½·range) head ms (median ±½·range) Δ % p
poi_calc_centroids_nocrop 3.84 ±0.03 3.53 ±0.07 -8.0% 0.000
nii_filter_connected_components 3.60 ±0.09 3.46 ±0.05 -3.9% 0.010
poi_calc_poi_from_subreg_vert 9.61 ±0.18 9.33 ±0.11 -3.0% 0.021
nii_fill_holes 3.93 ±0.06 3.83 ±0.06 -2.5% 0.027
nii_rescale 31.71 ±0.18 31.33 ±0.17 -1.2% 0.008
… 31 more measurements
Measurement baseline ms (median ±½·range) head ms (median ±½·range) Δ % p
nii_load_img 9.30 ±0.11 9.36 ±0.15 +0.7% 0.212
nii_save 9.31 ±0.13 9.29 ±0.11 -0.2% 0.784
nii_erode_msk 4.98 ±0.08 4.99 ±0.14 +0.2% 0.743
nii_dilate_msk 92.49 ±0.47 92.64 ±0.46 +0.2% 0.584
nii_resample_from_to 32.52 ±0.27 32.56 ±0.15 +0.1% 0.525
metric_voxels 250463.00 ±0.00 250463.00 ±0.00 +0.0% —
metric_labels 3.00 ±0.00 3.00 ±0.00 +0.0% —
metric_foreground_pct 14.51 ±0.00 14.51 ±0.00 +0.0% —
poi_resample_from_to 0.63 ±0.03 0.41 ±0.04 -35.0% (noise) 0.001
poi_map_labels 0.18 ±0.02 0.12 ±0.01 -31.3% (noise) 0.001
poi_save 0.45 ±0.03 0.33 ±0.03 -25.7% (noise) 0.000
nii_get_array 0.04 ±0.00 0.05 ±0.01 +23.8% (noise) 0.017
nii_extract_label 0.45 ±0.02 0.35 ±0.03 -20.7% (noise) 0.000
poi_to_global 0.19 ±0.02 0.15 ±0.01 -19.5% (noise) 0.008
poi_load 0.84 ±0.01 0.70 ±0.01 -17.6% (noise) 0.000
nii_map_labels 0.82 ±0.03 0.70 ±0.04 -15.3% (noise) 0.001
nii_center_of_masses 1.70 ±0.03 1.47 ±0.02 -13.7% (noise) 0.000
poi_rescale 0.21 ±0.02 0.18 ±0.02 -12.1% (noise) 0.025
nii_volumes 1.76 ±0.03 1.56 ±0.05 -11.1% (noise) 0.001
poi_calc_centroids 2.32 ±0.08 2.07 ±0.06 -10.7% (noise) 0.000
nii_load_seg 2.17 ±0.04 2.40 ±0.11 +10.6% (noise) 0.003
nii_get_connected_components 1.88 ±0.02 1.68 ±0.02 -10.5% (noise) 0.000
poi_local_to_global_arr 0.24 ±0.01 0.21 ±0.01 -9.8% (noise) 0.001
nii_set_dtype 0.48 ±0.05 0.45 ±0.03 -7.6% (noise) 0.374
nii_pad_to 0.56 ±0.02 0.52 ±0.03 -7.2% (noise) 0.025
nii_unique 0.49 ±0.02 0.52 ±0.01 +5.5% (noise) 0.140
nii_reorient 0.75 ±0.07 0.71 ±0.03 -5.1% (noise) 0.622
nii_compute_crop 0.29 ±0.01 0.28 ±0.01 -4.1% (noise) 0.327
nii_rescale_seg 2.61 ±0.02 2.52 ±0.05 -3.5% (noise) 0.014
nii_apply_crop 0.51 ±0.02 0.53 ±0.07 +3.2% (noise) 0.183
poi_reorient 0.33 ±0.04 0.33 ±0.02 -0.7% (noise) 0.370

ct_2d — shape (73, 47, 1)

Measurement baseline ms (median ±½·range) head ms (median ±½·range) Δ % p
nii_resample_from_to 5.86 ±0.09 6.01 ±0.13 +2.5% 0.098
nii_dilate_msk 10.81 ±0.07 10.91 ±0.19 +1.0% 0.127
nii_rescale 4.75 ±0.19 4.72 ±0.14 -0.7% 0.402
metric_voxels 3431.00 ±0.00 3431.00 ±0.00 +0.0% —
metric_labels 3.00 ±0.00 3.00 ±0.00 +0.0% —
… 30 more measurements
Measurement baseline ms (median ±½·range) head ms (median ±½·range) Δ % p
metric_foreground_pct 37.60 ±0.00 37.60 ±0.00 +0.0% —
poi_rescale 0.22 ±0.01 0.26 ±0.00 +14.7% (noise) 0.000
poi_to_global 0.23 ±0.01 0.26 ±0.00 +14.5% (noise) 0.001
nii_extract_label 0.41 ±0.01 0.46 ±0.02 +11.2% (noise) 0.003
poi_reorient 0.40 ±0.02 0.44 ±0.01 +8.8% (noise) 0.029
poi_load 0.86 ±0.01 0.91 ±0.02 +6.3% (noise) 0.000
poi_local_to_global_arr 0.25 ±0.00 0.27 ±0.01 +5.9% (noise) 0.006
nii_set_dtype 0.42 ±0.01 0.39 ±0.01 -5.7% (noise) 0.005
nii_erode_msk 0.88 ±0.00 0.83 ±0.02 -5.4% (noise) 0.009
poi_save 0.48 ±0.01 0.50 ±0.00 +5.1% (noise) 0.022
nii_load_seg 1.53 ±0.05 1.46 ±0.04 -4.8% (noise) 0.004
nii_get_array 0.02 ±0.00 0.02 ±0.00 +4.1% (noise) 0.869
poi_calc_centroids 0.89 ±0.03 0.85 ±0.02 -4.0% (noise) 0.019
nii_reorient 0.79 ±0.03 0.76 ±0.01 -4.0% (noise) 0.250
nii_map_labels 0.50 ±0.04 0.48 ±0.02 -3.7% (noise) 0.268
nii_filter_connected_components 0.77 ±0.04 0.75 ±0.02 -3.7% (noise) 0.165
poi_calc_centroids_nocrop 0.98 ±0.02 1.01 ±0.03 +3.4% (noise) 0.061
nii_compute_crop 0.15 ±0.01 0.15 ±0.01 -2.9% (noise) 0.474
nii_unique 0.13 ±0.00 0.13 ±0.01 -2.9% (noise) 0.997
nii_load_img 1.31 ±0.03 1.34 ±0.03 +2.7% (noise) 0.340
poi_resample_from_to 0.67 ±0.01 0.68 ±0.01 +2.5% (noise) 0.007
nii_apply_crop 0.66 ±0.01 0.64 ±0.02 -2.2% (noise) 0.463
nii_get_connected_components 0.61 ±0.01 0.62 ±0.02 +2.0% (noise) 0.347
nii_fill_holes 0.74 ±0.02 0.73 ±0.02 -1.7% (noise) 0.286
nii_rescale_seg 0.74 ±0.01 0.75 ±0.02 +1.5% (noise) 0.578
nii_pad_to 0.54 ±0.03 0.54 ±0.02 -0.9% (noise) 0.349
nii_center_of_masses 0.20 ±0.01 0.20 ±0.01 -0.6% (noise) 0.853
nii_volumes 0.28 ±0.01 0.28 ±0.01 -0.6% (noise) 0.762
poi_map_labels 0.20 ±0.01 0.20 ±0.01 -0.3% (noise) 0.160
nii_save 1.31 ±0.05 1.31 ±0.04 -0.0% (noise) 0.818

mri_3d — shape (68, 52, 67)

Measurement baseline ms (median ±½·range) head ms (median ±½·range) Δ % p
nii_fill_holes 4.93 ±0.06 5.10 ±0.02 +3.4% 0.004
nii_erode_msk 6.51 ±0.11 6.68 ±0.08 +2.7% 0.103
nii_filter_connected_components 3.82 ±0.02 3.91 ±0.05 +2.4% 0.015
poi_calc_poi_from_subreg_vert 8.92 ±0.07 9.11 ±0.10 +2.2% 0.020
nii_load_img 7.74 ±0.16 7.88 ±0.06 +1.8% 0.019
… 31 more measurements
Measurement baseline ms (median ±½·range) head ms (median ±½·range) Δ % p
nii_rescale 29.95 ±0.16 30.47 ±0.21 +1.7% 0.006
nii_save 7.70 ±0.03 7.82 ±0.09 +1.6% 0.017
poi_calc_centroids_nocrop 7.37 ±0.04 7.45 ±0.05 +1.1% 0.015
nii_dilate_msk 121.24 ±0.53 121.67 ±0.32 +0.4% 0.389
nii_resample_from_to 31.63 ±0.21 31.67 ±0.12 +0.1% 0.388
metric_voxels 236912.00 ±0.00 236912.00 ±0.00 +0.0% —
metric_labels 8.00 ±0.00 8.00 ±0.00 +0.0% —
metric_foreground_pct 18.21 ±0.00 18.21 ±0.00 +0.0% —
poi_reorient 0.45 ±0.01 0.49 ±0.02 +9.0% (noise) 0.005
nii_compute_crop 0.34 ±0.01 0.36 ±0.01 +6.5% (noise) 0.000
poi_rescale 0.28 ±0.00 0.30 ±0.01 +6.5% (noise) 0.002
nii_map_labels 0.91 ±0.01 0.96 ±0.02 +6.1% (noise) 0.001
poi_map_labels 0.24 ±0.01 0.26 ±0.01 +6.1% (noise) 0.077
poi_resample_from_to 0.71 ±0.01 0.75 ±0.01 +5.6% (noise) 0.000
nii_extract_label 0.45 ±0.00 0.48 ±0.01 +5.2% (noise) 0.008
nii_reorient 0.82 ±0.02 0.87 ±0.01 +5.1% (noise) 0.000
poi_save 0.53 ±0.02 0.56 ±0.03 +4.7% (noise) 0.036
nii_apply_crop 0.71 ±0.01 0.73 ±0.01 +3.9% (noise) 0.009
nii_get_array 0.05 ±0.02 0.05 ±0.00 -3.8% (noise) 0.482
nii_set_dtype 0.52 ±0.01 0.54 ±0.01 +3.1% (noise) 0.175
poi_calc_centroids 2.39 ±0.03 2.46 ±0.01 +3.1% (noise) 0.002
nii_unique 0.54 ±0.01 0.55 ±0.01 +3.0% (noise) 0.039
nii_get_connected_components 1.78 ±0.01 1.84 ±0.02 +3.0% (noise) 0.000
poi_load 1.73 ±0.02 1.78 ±0.02 +2.6% (noise) 0.009
poi_local_to_global_arr 0.27 ±0.01 0.26 ±0.01 -2.4% (noise) 0.158
nii_load_seg 2.57 ±0.04 2.63 ±0.69 +2.1% (noise) 0.304
nii_rescale_seg 2.58 ±0.01 2.62 ±0.03 +1.7% (noise) 0.052
nii_center_of_masses 1.68 ±0.01 1.70 ±0.02 +1.1% (noise) 0.042
poi_to_global 0.28 ±0.01 0.29 ±0.01 +0.4% (noise) 0.522
nii_pad_to 0.75 ±0.02 0.75 ±0.02 -0.2% (noise) 0.446
nii_volumes 1.71 ±0.02 1.71 ±0.01 -0.0% (noise) 0.732

mri_2d — shape (68, 52, 1)

Measurement baseline ms (median ±½·range) head ms (median ±½·range) Δ % p
nii_resample_from_to 5.63 ±0.05 6.29 ±0.11 +11.7% 0.000
nii_rescale 4.54 ±0.11 4.80 ±0.04 +5.7% 0.005
nii_dilate_msk 14.36 ±0.09 14.45 ±0.05 +0.7% 0.479
metric_voxels 3536.00 ±0.00 3536.00 ±0.00 +0.0% —
metric_labels 7.00 ±0.00 7.00 ±0.00 +0.0% —
… 30 more measurements
Measurement baseline ms (median ±½·range) head ms (median ±½·range) Δ % p
metric_foreground_pct 50.17 ±0.00 50.17 ±0.00 +0.0% —
nii_compute_crop 0.13 ±0.02 0.16 ±0.01 +24.9% (noise) 0.011
nii_get_array 0.02 ±0.00 0.02 ±0.00 +21.8% (noise) 0.020
nii_save 1.20 ±0.02 1.33 ±0.02 +11.1% (noise) 0.000
nii_rescale_seg 0.69 ±0.02 0.76 ±0.04 +10.5% (noise) 0.005
nii_pad_to 0.53 ±0.03 0.59 ±0.01 +10.0% (noise) 0.010
nii_set_dtype 0.39 ±0.03 0.43 ±0.01 +9.4% (noise) 0.012
nii_reorient 0.74 ±0.02 0.80 ±0.02 +7.9% (noise) 0.002
nii_center_of_masses 0.34 ±0.00 0.37 ±0.02 +7.3% (noise) 0.053
nii_load_img 1.34 ±0.02 1.43 ±0.04 +6.7% (noise) 0.002
poi_resample_from_to 0.72 ±0.03 0.68 ±0.01 -4.8% (noise) 0.056
nii_apply_crop 0.66 ±0.02 0.69 ±0.01 +4.7% (noise) 0.048
nii_erode_msk 1.08 ±0.01 1.03 ±0.01 -4.1% (noise) 0.000
nii_volumes 0.42 ±0.02 0.40 ±0.01 -4.1% (noise) 0.102
nii_map_labels 0.52 ±0.02 0.50 ±0.02 -4.0% (noise) 0.183
nii_extract_label 0.44 ±0.01 0.42 ±0.01 -3.8% (noise) 0.012
nii_unique 0.13 ±0.01 0.14 ±0.00 +3.3% (noise) 0.565
poi_reorient 0.46 ±0.01 0.44 ±0.02 -3.2% (noise) 0.204
nii_load_seg 1.52 ±0.03 1.55 ±0.04 +2.5% (noise) 0.041
poi_save 0.54 ±0.02 0.56 ±0.02 +2.1% (noise) 0.371
nii_get_connected_components 0.63 ±0.02 0.64 ±0.02 +2.0% (noise) 0.217
poi_map_labels 0.23 ±0.00 0.23 ±0.09 +1.3% (noise) 0.369
nii_fill_holes 0.93 ±0.02 0.92 ±0.03 -1.2% (noise) 0.659
poi_calc_centroids_nocrop 1.23 ±0.02 1.24 ±0.02 +1.1% (noise) 0.969
poi_to_global 0.27 ±0.01 0.27 ±0.01 -0.8% (noise) 0.505
poi_load 1.57 ±0.02 1.58 ±0.01 +0.8% (noise) 0.468
poi_calc_centroids 1.04 ±0.03 1.03 ±0.02 -0.8% (noise) 0.951
poi_rescale 0.28 ±0.01 0.28 ±0.02 +0.7% (noise) 0.643
nii_filter_connected_components 0.80 ±0.01 0.80 ±0.02 +0.5% (noise) 0.283
poi_local_to_global_arr 0.25 ±0.00 0.25 ±0.00 +0.1% (noise) 0.940

Gate: a measurement fails when the baseline is ≥ 1 ms, the median grows by ≥ 50%, and Welch's t-test gives p < 0.05. metric_* rows are context only.

Memory (peak RSS growth per call)

baseline 974263a vs head 974263a · python 3.11.16 · 5 repeats + 1 warmup · sampler proc-status, isolation fork · measurement floor ≈ 0.90 MiB

Showing the 5 most-changed measurements per case; the rest are collapsed. Rows with a baseline below 3 MiB are tagged (noise) — runner jitter on those swamps any real change.

ct_3d — shape (73, 47, 73)

Measurement baseline MiB (median ±½·range) head MiB (median ±½·range) Δ % p
poi_resample_from_to 5.43 ±0.00 5.51 ±0.00 +1.5% —
nii_reorient 5.87 ±0.00 5.95 ±0.00 +1.4% —
nii_load_seg 5.97 ±0.00 6.05 ±0.00 +1.3% —
nii_rescale 6.32 ±0.00 6.40 ±0.00 +1.3% —
nii_resample_from_to 6.45 ±0.00 6.53 ±0.00 +1.3% —
… 31 more measurements
Measurement baseline MiB (median ±½·range) head MiB (median ±½·range) Δ % p
nii_erode_msk 5.98 ±0.00 6.05 ±0.00 +1.2% —
nii_load_img 3.52 ±0.00 3.56 ±0.00 +1.1% —
nii_dilate_msk 5.99 ±0.00 6.04 ±0.00 +0.8% —
nii_set_dtype 5.31 ±0.00 5.35 ±0.00 +0.8% —
nii_pad_to 5.43 ±0.00 5.47 ±0.00 +0.8% —
nii_extract_label 5.43 ±0.00 5.48 ±0.00 +0.8% —
nii_map_labels 5.50 ±0.00 5.54 ±0.00 +0.8% —
nii_apply_crop 5.87 ±0.00 5.91 ±0.00 +0.7% —
poi_calc_centroids_nocrop 5.99 ±0.00 6.04 ±0.00 +0.7% —
poi_calc_centroids 6.12 ±0.00 6.16 ±0.00 +0.7% —
nii_rescale_seg 6.13 ±0.00 6.18 ±0.00 +0.7% —
nii_get_connected_components 6.62 ±0.00 6.66 ±0.00 +0.6% —
nii_filter_connected_components 6.93 ±0.00 6.98 ±0.00 +0.6% —
nii_fill_holes 6.35 ±0.00 6.39 ±0.00 +0.6% —
poi_calc_poi_from_subreg_vert 7.24 ±0.00 7.28 ±0.00 +0.6% —
poi_local_to_global_arr 3.02 ±0.00 3.02 ±0.00 +0.1% —
poi_to_global 3.14 ±0.00 3.14 ±0.00 +0.1% —
nii_center_of_masses 3.21 ±0.00 3.21 ±0.00 +0.1% —
nii_volumes 3.52 ±0.00 3.52 ±0.00 +0.1% —
nii_save 3.83 ±0.00 3.83 ±0.00 +0.1% —
poi_reorient 3.89 ±0.00 3.89 ±0.00 +0.1% —
metric_voxels 250463.00 ±0.00 250463.00 ±0.00 +0.0% —
metric_labels 3.00 ±0.00 3.00 ±0.00 +0.0% —
metric_foreground_pct 14.51 ±0.00 14.51 ±0.00 +0.0% —
poi_save 1.46 ±0.00 1.46 ±0.00 +0.3% (noise) —
poi_load 1.61 ±0.00 1.61 ±0.00 +0.2% (noise) —
nii_get_array 1.64 ±0.00 1.65 ±0.00 +0.2% (noise) —
poi_map_labels 1.77 ±0.00 1.77 ±0.00 +0.2% (noise) —
poi_rescale 2.60 ±0.00 2.61 ±0.00 +0.2% (noise) —
nii_unique 2.89 ±0.00 2.90 ±0.00 +0.1% (noise) —
nii_compute_crop 2.96 ±0.00 2.96 ±0.00 +0.1% (noise) —

ct_2d — shape (73, 47, 1)

Measurement baseline MiB (median ±½·range) head MiB (median ±½·range) Δ % p
poi_resample_from_to 5.37 ±0.00 5.45 ±0.00 +1.5% —
nii_reorient 5.81 ±0.00 5.89 ±0.00 +1.4% —
nii_load_seg 5.91 ±0.00 5.99 ±0.00 +1.3% —
nii_rescale 6.26 ±0.00 6.34 ±0.00 +1.3% —
nii_resample_from_to 6.38 ±0.00 6.46 ±0.00 +1.3% —
… 30 more measurements
Measurement baseline MiB (median ±½·range) head MiB (median ±½·range) Δ % p
nii_erode_msk 5.92 ±0.00 5.99 ±0.00 +1.2% —
nii_load_img 3.46 ±0.00 3.50 ±0.00 +1.1% —
nii_dilate_msk 5.93 ±0.00 5.98 ±0.00 +0.9% —
nii_set_dtype 5.25 ±0.00 5.29 ±0.00 +0.8% —
nii_pad_to 5.37 ±0.00 5.41 ±0.00 +0.8% —
nii_extract_label 5.37 ±0.00 5.41 ±0.00 +0.8% —
nii_map_labels 5.43 ±0.00 5.48 ±0.00 +0.8% —
nii_apply_crop 5.80 ±0.00 5.85 ±0.00 +0.7% —
poi_calc_centroids_nocrop 5.99 ±0.00 6.04 ±0.00 +0.7% —
poi_calc_centroids 6.06 ±0.00 6.10 ±0.00 +0.7% —
nii_rescale_seg 6.07 ±0.00 6.11 ±0.00 +0.7% —
nii_get_connected_components 6.56 ±0.00 6.60 ±0.00 +0.7% —
nii_filter_connected_components 6.87 ±0.00 6.91 ±0.00 +0.6% —
nii_fill_holes 6.29 ±0.00 6.33 ±0.00 +0.6% —
poi_to_global 3.08 ±0.00 3.08 ±0.00 +0.1% —
nii_center_of_masses 3.14 ±0.00 3.15 ±0.00 +0.1% —
nii_volumes 3.46 ±0.00 3.46 ±0.00 +0.1% —
nii_save 3.77 ±0.00 3.77 ±0.00 +0.1% —
poi_reorient 3.83 ±0.00 3.83 ±0.00 +0.1% —
metric_voxels 3431.00 ±0.00 3431.00 ±0.00 +0.0% —
metric_labels 3.00 ±0.00 3.00 ±0.00 +0.0% —
metric_foreground_pct 37.60 ±0.00 37.60 ±0.00 +0.0% —
poi_save 1.39 ±0.00 1.40 ±0.00 +0.3% (noise) —
poi_load 1.55 ±0.00 1.55 ±0.00 +0.3% (noise) —
nii_get_array 1.58 ±0.00 1.59 ±0.00 +0.2% (noise) —
poi_map_labels 1.71 ±0.00 1.71 ±0.00 +0.2% (noise) —
poi_rescale 2.54 ±0.00 2.54 ±0.00 +0.2% (noise) —
nii_unique 2.83 ±0.00 2.84 ±0.00 +0.1% (noise) —
nii_compute_crop 2.89 ±0.00 2.90 ±0.00 +0.1% (noise) —
poi_local_to_global_arr 2.95 ±0.00 2.96 ±0.00 +0.1% (noise) —

mri_3d — shape (68, 52, 67)

Measurement baseline MiB (median ±½·range) head MiB (median ±½·range) Δ % p
poi_resample_from_to 5.37 ±0.00 5.45 ±0.00 +1.5% —
nii_reorient 5.81 ±0.00 5.89 ±0.00 +1.4% —
nii_load_seg 5.91 ±0.00 5.99 ±0.00 +1.3% —
nii_rescale 6.26 ±0.00 6.34 ±0.00 +1.3% —
nii_resample_from_to 6.38 ±0.00 6.46 ±0.00 +1.3% —
… 31 more measurements
Measurement baseline MiB (median ±½·range) head MiB (median ±½·range) Δ % p
nii_erode_msk 5.92 ±0.00 5.99 ±0.00 +1.2% —
nii_load_img 3.52 ±0.00 3.56 ±0.00 +1.1% —
nii_dilate_msk 5.93 ±0.00 5.98 ±0.00 +0.9% —
nii_set_dtype 5.31 ±0.00 5.35 ±0.00 +0.8% —
nii_pad_to 5.37 ±0.00 5.41 ±0.00 +0.8% —
nii_extract_label 5.37 ±0.00 5.41 ±0.00 +0.8% —
nii_map_labels 5.43 ±0.00 5.48 ±0.00 +0.8% —
nii_apply_crop 5.80 ±0.00 5.85 ±0.00 +0.7% —
poi_calc_centroids_nocrop 5.93 ±0.00 5.97 ±0.00 +0.7% —
poi_calc_centroids 6.06 ±0.00 6.10 ±0.00 +0.7% —
nii_rescale_seg 6.07 ±0.00 6.11 ±0.00 +0.7% —
nii_get_connected_components 6.56 ±0.00 6.60 ±0.00 +0.7% —
nii_filter_connected_components 6.87 ±0.00 6.91 ±0.00 +0.6% —
nii_fill_holes 6.29 ±0.00 6.33 ±0.00 +0.6% —
poi_calc_poi_from_subreg_vert 7.24 ±0.00 7.28 ±0.00 +0.6% —
poi_to_global 3.08 ±0.00 3.08 ±0.00 +0.1% —
nii_center_of_masses 3.14 ±0.00 3.15 ±0.00 +0.1% —
nii_volumes 3.46 ±0.00 3.46 ±0.00 +0.1% —
nii_save 3.77 ±0.00 3.77 ±0.00 +0.1% —
poi_reorient 3.83 ±0.00 3.83 ±0.00 +0.1% —
metric_voxels 236912.00 ±0.00 236912.00 ±0.00 +0.0% —
metric_labels 8.00 ±0.00 8.00 ±0.00 +0.0% —
metric_foreground_pct 18.21 ±0.00 18.21 ±0.00 +0.0% —
poi_save 1.46 ±0.00 1.46 ±0.00 +0.3% (noise) —
poi_load 1.55 ±0.00 1.55 ±0.00 +0.3% (noise) —
nii_get_array 1.58 ±0.00 1.59 ±0.00 +0.2% (noise) —
poi_map_labels 1.71 ±0.00 1.71 ±0.00 +0.2% (noise) —
poi_rescale 2.54 ±0.00 2.54 ±0.00 +0.2% (noise) —
nii_unique 2.83 ±0.00 2.84 ±0.00 +0.1% (noise) —
nii_compute_crop 2.89 ±0.00 2.90 ±0.00 +0.1% (noise) —
poi_local_to_global_arr 2.95 ±0.00 2.96 ±0.00 +0.1% (noise) —

mri_2d — shape (68, 52, 1)

Measurement baseline MiB (median ±½·range) head MiB (median ±½·range) Δ % p
poi_resample_from_to 5.37 ±0.00 5.45 ±0.00 +1.5% —
nii_reorient 5.81 ±0.00 5.89 ±0.00 +1.4% —
nii_load_seg 5.91 ±0.00 5.99 ±0.00 +1.3% —
nii_rescale 6.26 ±0.00 6.34 ±0.00 +1.3% —
nii_resample_from_to 6.38 ±0.00 6.46 ±0.00 +1.3% —
… 30 more measurements
Measurement baseline MiB (median ±½·range) head MiB (median ±½·range) Δ % p
nii_erode_msk 5.92 ±0.00 5.99 ±0.00 +1.2% —
nii_load_img 3.52 ±0.00 3.56 ±0.00 +1.1% —
nii_dilate_msk 5.93 ±0.00 5.98 ±0.00 +0.9% —
nii_set_dtype 5.31 ±0.00 5.35 ±0.00 +0.8% —
nii_pad_to 5.37 ±0.00 5.41 ±0.00 +0.8% —
nii_extract_label 5.37 ±0.00 5.41 ±0.00 +0.8% —
nii_map_labels 5.43 ±0.00 5.48 ±0.00 +0.8% —
nii_apply_crop 5.80 ±0.00 5.85 ±0.00 +0.7% —
poi_calc_centroids_nocrop 5.99 ±0.00 6.04 ±0.00 +0.7% —
poi_calc_centroids 6.06 ±0.00 6.10 ±0.00 +0.7% —
nii_rescale_seg 6.07 ±0.00 6.11 ±0.00 +0.7% —
nii_get_connected_components 6.56 ±0.00 6.60 ±0.00 +0.7% —
nii_filter_connected_components 6.87 ±0.00 6.91 ±0.00 +0.6% —
nii_fill_holes 6.29 ±0.00 6.33 ±0.00 +0.6% —
poi_to_global 3.08 ±0.00 3.08 ±0.00 +0.1% —
nii_center_of_masses 3.14 ±0.00 3.15 ±0.00 +0.1% —
nii_volumes 3.46 ±0.00 3.46 ±0.00 +0.1% —
nii_save 3.77 ±0.00 3.77 ±0.00 +0.1% —
poi_reorient 3.83 ±0.00 3.83 ±0.00 +0.1% —
metric_voxels 3536.00 ±0.00 3536.00 ±0.00 +0.0% —
metric_labels 7.00 ±0.00 7.00 ±0.00 +0.0% —
metric_foreground_pct 50.17 ±0.00 50.17 ±0.00 +0.0% —
poi_save 1.46 ±0.00 1.46 ±0.00 +0.3% (noise) —
poi_load 1.55 ±0.00 1.55 ±0.00 +0.3% (noise) —
nii_get_array 1.58 ±0.00 1.59 ±0.00 +0.2% (noise) —
poi_map_labels 1.71 ±0.00 1.71 ±0.00 +0.2% (noise) —
poi_rescale 2.54 ±0.00 2.54 ±0.00 +0.2% (noise) —
nii_unique 2.83 ±0.00 2.84 ±0.00 +0.1% (noise) —
nii_compute_crop 2.89 ±0.00 2.90 ±0.00 +0.1% (noise) —
poi_local_to_global_arr 2.95 ±0.00 2.96 ±0.00 +0.1% (noise) —

Gate: a measurement fails when the baseline is ≥ 1 MiB, the median grows by ≥ 50%, and Welch's t-test gives p < 0.05. metric_* rows are context only.

Comment thread TPTBox/segmentation/rib/_rib_assign.py Outdated
# Merge rib assignments back into the original vert / sem segmentations
# without disturbing existing (non-rib) labels. Skip unmatched CCs (sentinel error_value=255).
matched = (rib_inst != 0) & (rib_inst != error_value)
print("rib_inst", rib_inst.dtype, rib_inst.seg)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not use our logging, remove

@Hendrik-code

Copy link
Copy Markdown
Owner

this is just style-changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants