Repository navigation
fix: accept null code and group_id in the custom field response - #22
Merged
Merged
Conversation
amoCRM answers custom_fields.get_by_id with explicit nulls for code and group_id. The non-nilable CustomField variant rejected them, so the union picked Problem and a successful response was read as an error. Fixes #19
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Живой amoCRM отдаёт
nullпоcodeиgroup_id; не-nilable вариантCustomFieldих отвергал, и союз выбиралProblem. Поля помечены nilable в lib/rbi/sig, добавлен тест на живую форму ответа (падает без фикса).Fixes #19