Repository navigation
Conversation
Add a function that converts a duty cycle percentage into duty cycle ticks that helps to initialize correctly .Pulse without hardcoding it
…into feat/adjv3-protections initial commit
| namespace ST_LIB { | ||
| struct ProtectionMessagePacket { | ||
|
|
||
| struct Package_Data { |
There was a problem hiding this comment.
Do not call it Package_Data, the name generates confusión with the packets of type data`
| #else | ||
| pack.data.hours = 0; pack.data.minutes = 0; pack.data.seconds = 0; | ||
| #endif | ||
| pack.data.reserved = 0; |
| #include "lwip/tcp.h" | ||
|
|
||
| namespace ST_LIB { | ||
| struct ProtectionMessagePacket { |
There was a problem hiding this comment.
Do not call it like because it might generate confusion between Protection and Message which are both
There was a problem hiding this comment.
I'm also trying to think of a better name...
|
@Sagah123 I've changed the status of the PR to draft. |
|
Please move the implementation to |
|
If your pull request is unfinished, start with a draft, when you want to recieve reviews click the 'ready for review' button (saying just in case because @JavierRibaldelRio left a pretty detailed review and it looked like this code hasn't been tested yet) |
|
Use get_rtc_timestamp when sending the package, not when making it, to get the correct timestamp |
…error detection. Change provisional name to ProtectionADJV3Packet
ST-LIB Release Plan
Pending changes
|
|
I fixed all of your conversations except naming, also, the format check is failing because of CHANGELOG.md, not my changes, so please dont take it into account |
victor-Lopez25
left a comment
victor-Lopez25
left a comment
There was a problem hiding this comment.
Just a couple small changes now
victor-Lopez25
left a comment
victor-Lopez25
left a comment
There was a problem hiding this comment.
We'll talk about changing the format checks soon after exams but the rest is good
I've implemented a first version of ProtectionMessage and I need your opinion (CMake, format etc are pending to edit)
also i left a few comments explaining or asking things