root - chore: defense - lint workflows with zizmor - #71
Conversation
Add check-workflows.yaml so every PR runs zizmor with Socket Firewall in front. Reconcile Socket Firewall as merged in PR #70. Co-authored-by: Jared Wray <me@jaredwray.com>
Co-authored-by: Jared Wray <me@jaredwray.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in DEFENSE_IN_DEPTH.md and SECURITY.md to reflect that Socket Firewall (sfw) has been integrated to wrap pnpm install across CI jobs. I have no feedback to provide as there are no review comments or issues identified in these documentation updates.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…eckouts (#72) * root - chore: defense - disable persist-credentials on non-pushing checkouts Stop writing GITHUB_TOKEN into .git/config on tests, release, and code-coverage jobs. Reconcile zizmor as merged in PR #71. Co-authored-by: Jared Wray <me@jaredwray.com> * docs: mark persist-credentials as PR #72 pending Co-authored-by: Jared Wray <me@jaredwray.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
CI / supply-chain hardening.
Summary
Adds
.github/workflows/check-workflows.yamlso zizmor lints Actions workflows on every PR (defense-in-depth § 4).Status update
DEFENSE_IN_DEPTH.md: zizmor check-workflows → (PR #71 pending); Socket Firewall → PR #70Changes
check-workflowswith SHA-pinned checkout, Socket Firewall, andzizmorcore/zizmor-actionVerification
firewall-version: 1.15.1npx actions-up -y --style sha --min-age 1zizmor,tests(build-test22/24/26),code-coverage(build), CodeQLReference
defense-in-depth-nodejs § 4