root - chore: defense - disable setup-node cache on release - #73
Merged
Merged
Conversation
Set package-manager-cache: false on the artifact-publishing release workflow so a poisoned Actions cache cannot run in a job that holds publish credentials. Reconcile persist-credentials as merged in PR #72. Co-authored-by: Jared Wray <me@jaredwray.com>
Co-authored-by: Jared Wray <me@jaredwray.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
jaredwray
marked this pull request as ready for review
September 9, 2026 21:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
jaredwray
added a commit
that referenced
this pull request
Sep 9, 2026
* root - chore: defense - stage npm publishes from packed tarballs Switch release.yaml from live pnpm publish to pack + pnpm stage publish so a CI run can only stage. Reconcile setup-node cache as PR #73 and record that workflows do not use npm registry tokens (OIDC id-token). Co-authored-by: Jared Wray <me@jaredwray.com> * docs: mark stage publish as PR #74 pending Co-authored-by: Jared Wray <me@jaredwray.com> * docs: leave npm-token secrets item unchecked Codex is right that workflow YAML cannot prove Actions secrets are empty. Keep the catalog item pending until secrets:read can inspect them. Co-authored-by: Jared Wray <me@jaredwray.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
CI / supply-chain hardening.
Summary
Disables
actions/setup-nodedefault package-manager caching on the artifact-publishingreleaseworkflow (defense-in-depth § 4).Status update
DEFENSE_IN_DEPTH.md: setup-node package-manager-cache → (PR #73 pending); persist-credentials → PR #72Changes
package-manager-cache: falseonrelease.yamlactions/setup-node(nocache:package manager)cache: pnpmon regular CI (tests,code-coverage)SECURITY.mdVerification
release.yamlis the only artifact-publishing / OIDC workflowsetup-nodestep setspackage-manager-cache: falseand does not setcache:Reference
defense-in-depth-nodejs § 4