Conversation
jimnel
commented
Jul 27, 2026
jimnel
commented
Jul 27, 2026
Co-authored-by: James Nelson <janelson@tcd.ie>
pablosuvi
reviewed
Aug 11, 2026
pablosuvi
left a comment
pablosuvi
left a comment
Collaborator
There was a problem hiding this comment.
All good. Just one quick comment re-python versions
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.12"] |
Collaborator
There was a problem hiding this comment.
would be better maybe to test the CI/CD pipeline with more python versions? ["3.12", "3.13", "3.14"] ?
and also change the python vresion in the .toml file to >=3.12 ?
Contributor
Author
There was a problem hiding this comment.
I think since we don't have a large external user base testing with only one version of python is fine.
I'll update the python version.
pablosuvi
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple pipeline, currently only installing the package and running Ruff.