Repository navigation
fix(aggregate): allowlist filter_*/sum_* query params - #2858
Merged
Merged
Conversation
szabozoltan69
approved these changes
Oct 7, 2026
szabozoltan69
left a comment
Contributor
There was a problem hiding this comment.
Nice and readable, concise solution. Thanks for it!
susilnem
marked this pull request as ready for review
October 7, 2026 06:56
susilnem
force-pushed
the
fix/aggregate-lookup-allowlist
branch
2 times, most recently
from
October 12, 2026 05:15
22704ca to
6c8cc47
Compare
Member
Author
|
@szabozoltan69 , Can you merge this pull request and deploy on staging? |
susilnem
force-pushed
the
fix/aggregate-lookup-allowlist
branch
from
October 15, 2026 04:08
6c8cc47 to
ef1c06a
Compare
Member
Author
Staging verificationTested on staging against
Result: Only allowlisted params are accepted; arbitrary ORM lookups/aggregations no longer affect the query. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
filter_*/sum_*lookups from/api/v1/aggregate/(GO-API-4VW).filter_atype(appeal)sum_amount_funded=amount_funded(appeal)sum_beneficiaries=num_beneficiaries(appeal)filter_*/sum_*params are ignored.Note
Warning
External clients (e.g. PowerBI, partner scripts) might use other
filter_*/sum_*params. These will now be ignored. Please check before merging. If any are needed, we can add them to the allowlist.Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.