Repository navigation
Conversation
sandeshit
changed the title
| default=SummaryStatus.PENDING, | ||
| ) | ||
|
|
||
| section_status = models.JSONField( |
There was a problem hiding this comment.
section_status is write-only so, nothing reads it, and with all or nothing it doesn't change behavior. Do we need this?
There was a problem hiding this comment.
It is intentionally left for diagnosis and quick checks in case of failures.
| ) | ||
| raise SectionGenerationError("no LLM response") | ||
|
|
||
| def generate_all( |
There was a problem hiding this comment.
When a summary is retriggered, are all sections regenerated, or only the failed ones?
There was a problem hiding this comment.
All sections are regenerated.
There was a problem hiding this comment.
So, if one section fails, will all the other successful sections be retriggered?
There was a problem hiding this comment.
Yes dai. All or none is done
| default=SummaryStatus.PENDING, | ||
| ) | ||
|
|
||
| section_status = models.JSONField( |
There was a problem hiding this comment.
It isn't exposed in the serializer. Do we need to expose it or not? if yes then lets add on serializer.
There was a problem hiding this comment.
I do not think we need to expose this in the serializer. Its strictly for quick checks in case of failure only.
abaccec to
7af9714
Compare
2 participants
Changes
Checklist