Repository navigation
[TEST] LegalDocuments: Replace mock with stub for simpler testing - #12355
Open
mjansenDatabay wants to merge 1 commit into
Open
mjansenDatabay wants to merge 1 commit into
mjansenDatabay wants to merge 1 commit into
Conversation
lscharmer
requested changes
Nov 2, 2026
lscharmer
left a comment
lscharmer
left a comment
Contributor
There was a problem hiding this comment.
Not all notes must be fixed the only required ones are:
- Bug in ContainerMock::mockTree where $with_expectation is not propagated.
- Typehint doc blocks when the called method already declares the returned type completely (
$this->stub(...))
mjansenDatabay
force-pushed
the
hotfix/12/ldocs-test-stubs
branch
from
November 2, 2026 14:08
81533f2 to
64a7e33
Compare
Use stubTree/mockTree split, stub helpers, and mapExpecting for single Map calls. Chain set/add in hasPublicPageWithGotoLink via mockMethod per review.
mjansenDatabay
force-pushed
the
hotfix/12/ldocs-test-stubs
branch
from
November 5, 2026 11:32
64a7e33 to
ff1234e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified the test setup by substituting
mockwithstubwhere strict expectation verification is unnecessary. Updated related helper methods to accommodatestubcreation.