Skip to content

fix(build-logs): strip bidi overrides and C1 controls from build log output #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sivaratrisrinivas wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(build-logs): strip bidi overrides and C1 controls from build log output #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91829cb
fix(build-logs): strip bidi overrides and C1 controls from build log …
sivaratrisrinivas Oct 26, 2026
47a956e
test(build-logs): cover U+0080 at the C1 lower bound
sivaratrisrinivas Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/build-logs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export async function readBuildLogs(api: Api, projectId: string, source: BuildSo
return { ...first, nextCursor: undefined, state: pending ? 'pending' : first.state, steps, output }
}

const safeText = (text: string) => stripVTControlCharacters(text).replace(/[\x00-\x08\x0b-\x1f\x7f]/g, '')
const safeText = (text: string) => stripVTControlCharacters(text).replace(/[\x00-\x08\x0b-\x1f\x7f-\x9f\u200e\u200f\u202a-\u202e\u2066-\u2069]/g, '')

export class BuildLogPrinter {
private seen = new Map<string, number>()
Expand Down
7 changes: 7 additions & 0 deletions test/build-logs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ describe('build logs', () => {
expect(write.mock.calls.map(([text]) => text)).toEqual(['RUN test\n', 'same\n', 'same\n', 'late\n', 'same\n'])
})

it('strips bidi overrides, invisible marks and C1 controls while keeping tabs and newlines', () => {
const printer = new BuildLogPrinter()
const write = vi.fn()
printer.print({ ...base, state: 'ready', output: [{ step: 'step1', name: 'RUN test', entries: [entry('a\u202eb\u0080\u0085c\u2066d\u2069e\u200ef\u200fg\u202ah\u009fi\n'), entry('col1\tcol2\n'), entry('plain text ok\n')] }] }, write)
expect(write.mock.calls.map(([text]) => text)).toEqual(['RUN test\n', 'abcdefghi\n', 'col1\tcol2\n', 'plain text ok\n'])
})

it('resumes after transient errors and reads delayed terminal output', async () => {
let reads = 0
const api = apiWith((path) => {
Expand Down