Repository navigation
fix: preserve spaced Windows shim command lines - #385
Open
Fermionic-Lyu wants to merge 1 commit into
Open
Fermionic-Lyu wants to merge 1 commit into
Fermionic-Lyu wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows agent setup fails when the resolved
npx.cmdpath contains spaces:cmd.exe /s /cstrips the executable quotes and tries to run the first path component. Preserve a fully quoted command line through the shared resolver and its setup, skill-install, and upgrade callers.The wrapper disables delayed expansion, preserves trailing backslashes and empty arguments, and retains the shell-metacharacter rejection with CR/LF also rejected. No command or flag changes.
Validation: typecheck, build, and all 107 local test files pass (2259 tests; one Windows-only test skipped on macOS). The new Windows regression executes a real
.cmdshim under a spaced path and checks literal argv, including empty arguments, trailing backslashes, parentheses, and exclamation marks. Windows CI passed all 11 tests in this regression file; its full suite passed 2213 tests with 47 platform-specific skips. Linux CI also passed.Independent self-review and mutation checks completed before push. Cubic reported no issues across all 8 files. No release is included.