Skip to content

Fix repo-assist memory validation rejecting .git directory - #1454

Merged
BenjaminMichaelis merged 1 commit into
mainfrom
benjaminmichaelis-fix-repo-memory-validation
Oct 3, 2026
Merged

BenjaminMichaelis merged 1 commit into
mainfrom
benjaminmichaelis-fix-repo-memory-validation

Conversation

@BenjaminMichaelis

Copy link
Copy Markdown
Member

Fixes the Custom repo-memory validation failed for 'default' error in run 37099697573.

Cause

gh-aw sets memoryRoot to a git clone of memory/repo-assist, so the folder always contains .git next to notes.json. The validator required exactly one entry, so it failed even though the memory was valid.

Changes (.github/workflows/repo-assist.md + recompiled lock)

  • Skip .git before running the "only notes.json" check.
  • Remove the fs.rmSync legacy-file cleanup. gh-aw fails validators that change memory files, and the legacy files are already gone from the branch.
  • Set max-file-count back to 1, since the one-time legacy cleanup is finished.

Validation

  • gh aw compile repo-assist --strict succeeds.
  • Ran the compiled validator script against a real clone of memory/repo-assist. It passes, and still fails when an extra extra.json is added.

Security review note

gh aw compile flagged one item needing approval: Memory validation script changes: repo-memory:default (modified). That is the edit described above. It adds or removes no secrets, actions, or network access.

Not addressed

The same run also failed in the Copilot CLI step with 400 Invalid 'input[N].id': 'ctc_call_…'. Expected an ID that begins with 'fc'. That error comes from Copilot CLI or the gh-aw harness, not this repo, and should be reported upstream.

The repo-memory root is a git clone, so the exact-one-entry check always
failed on .git. Ignore .git, drop the legacy-file rmSync (gh-aw rejects
validators that modify memory), and restore max-file-count to 1 now that
legacy files are gone.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@BenjaminMichaelis
BenjaminMichaelis merged commit 2b5c6ca into main Oct 3, 2026
21 checks passed
@BenjaminMichaelis
BenjaminMichaelis deleted the benjaminmichaelis-fix-repo-memory-validation branch October 3, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant