Conversation
eboyer221
requested review from
AbhirupaGhosh,
amcim,
epbrenner and
jananiravi
September 18, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mergePanaroo()discarding itssystem2()result entirely, so a failedpanaroo-mergerun inside Docker previously failed silently. Now checks exit status and surfaces Docker's output, matching the pattern already used in.processPanaroo()..runCDHIT(),.runHmmerJob(), and bothhmmpress/hmmsearchcall sites in.defenseHMMER(), so Docker failures are caught by exit code, not just inferred from a missing file.R.utilstoDESCRIPTIONImports, it's used by.prepareHmmerDatabases()to gunzip the Pfam HMM download but was never declared as a dependency.runDataProcessing()'sclean_metadata_and_exportmanifest stage now records the 5 specific reference TSVscleanMetaData()reads (clean_drug.tsv,drug_class.tsv,drug_abbr.tsv,class_abbr.tsv,cleaned_bvbrc_countries.tsv) asinputs, instead of just theref_file_pathdirectory.Closes #59, #58. Addresses the remaining part of #48 (the Parquet-output itemization was already in place on main).
Test plan
devtools::test()— 46 passed, 0 failed, 0 skippedroxygen2::roxygenise()— no doc changes needed (internal logic only)EOF
)"