Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #146, which was accidentally closed and its source fork deleted. The implementation is unchanged; the original discussion and reviews remain linked there.
JSONPointerToSliceaccepts bare tildes and escapes such as~2, soSetJSONPointer("value", "/~2")silently creates a key instead of returning a syntax error. RFC 6901 section 3 permits only~0and~1escape sequences.Validate each encoded token before applying the existing replacements. Tests cover five invalid paths, verify that invalid writes leave the document unchanged, and retain valid escapes including
~01(which must decode to~1, not/).Validation: all five invalid-path cases fail before the fix.
go test -race -cover ./...passes (87.4% coverage), as do the CI-stylego test -count 100 ./...,go vet ./..., and staticcheck.