Skip to content

Align provider architecture gate source anchors - #8

Merged
Mjones13 merged 1 commit into
work/netdata-italian-localization-20261002-slot14from
work/netdata-architecture-anchors-20261002-slot14
Oct 7, 2026
Merged

Mjones13 merged 1 commit into
work/netdata-italian-localization-20261002-slot14from
work/netdata-architecture-anchors-20261002-slot14

Conversation

@Mjones13

@Mjones13 Mjones13 commented Oct 2, 2026 •

Copy link
Copy Markdown

The macOS architecture gate in parent PR #7 fails because three exact source-line coordinates still identify lines 300, 316 and 329 in PreferencesProvidersPane.swift. The unchanged guarded constructs now occupy lines 323, 339 and 352. This child updates only those three coordinates in the existing fixture. Anchor text, reasons, provider IDs, reference counts, fingerprints, scanner behavior and failures.isEmpty remain unchanged.

This is one file with three insertions and three deletions, based on PR #7 at 834c3582924f5ea3b44ae042c8d57f7c7a967fc5. Dependency order remains #2 → #4 → #5 → #6 → #7 → this child. Parent source branches and worktrees are unchanged.

Validation on the candidate:

  • The existing cross-provider gate method, complete lexical scanner/catalog/helper closure and genuine UsageProvider enum were copied verbatim into a contained Foundation/Swift Testing harness. It scanned the exact 1,170 immutable tracked Swift sources under Sources and WidgetExtension. Original coordinates reproduced the failure with three stale anchors and three consequent unmatched constructs; corrected coordinates passed the same one-test predicate. No assertion or scanner substitution.
  • Authenticated Swift 6.2 syntax parsing, pinned SwiftFormat 0.61.1 lint and whitespace checks passed.
  • Source and lock hashes stayed fixed, all owned process groups ended and temporary scratch was removed. No dependency downloads or system installation.

This Linux lexical check does not establish native macOS app typechecking or live Netdata acceptance. Parent PR #7's exact old-head CI is terminal failure: macOS shard 0 failed this gate, shard 1 and Linux jobs passed. The child’s hosted run 37076620634 passed lint, Linux x64/ARM64, both macOS shards and aggregate CI on this exact head; musl was skipped. Original native pending input, live/private route acceptance, NETDATA-CLIENT-01 P2 and NETDATA-DOC-01 P3 retain their existing dispositions. No workflow, runtime, provider-control or locale changes.

Contributors:

  • Original T3 thread: “Resume NetData Menu Bar Monitoring”, native ID 718b02d7-0d4b-4670-b05f-57a5db28178d; source objective.
  • Portfolio coordinator: “Orchestrated thread work stream processing”, /root; native T3 UUID unavailable in the bound context.
  • Source/Git owner: /root/portfolio_slot_14, isolated netdata-architecture-anchors-20261002-slot14 worktree; exact coordinate correction, verification and publication.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Delivery coordination: M Jones authorized merging the complete #2 → #4 → #5 → #6 → #7 → #8 chain on October 7, 2026. Resume NetData Menu Bar Monitoring (718b02d7-0d4b-4670-b05f-57a5db28178d) coordinates child-into-parent merges with current-head checks. Native live endpoint/polling/render acceptance remains separate.

@Mjones13
Mjones13 merged commit af323ae into work/netdata-italian-localization-20261002-slot14 Oct 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant