Repository navigation
Align provider architecture gate source anchors - #8
Merged
Conversation
Mjones13
merged commit Oct 7, 2026
af323ae
into
work/netdata-italian-localization-20261002-slot14
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS architecture gate in parent PR #7 fails because three exact source-line coordinates still identify lines 300, 316 and 329 in
PreferencesProvidersPane.swift. The unchanged guarded constructs now occupy lines 323, 339 and 352. This child updates only those three coordinates in the existing fixture. Anchor text, reasons, provider IDs, reference counts, fingerprints, scanner behavior andfailures.isEmptyremain unchanged.This is one file with three insertions and three deletions, based on PR #7 at
834c3582924f5ea3b44ae042c8d57f7c7a967fc5. Dependency order remains #2 → #4 → #5 → #6 → #7 → this child. Parent source branches and worktrees are unchanged.Validation on the candidate:
UsageProviderenum were copied verbatim into a contained Foundation/Swift Testing harness. It scanned the exact 1,170 immutable tracked Swift sources underSourcesandWidgetExtension. Original coordinates reproduced the failure with three stale anchors and three consequent unmatched constructs; corrected coordinates passed the same one-test predicate. No assertion or scanner substitution.This Linux lexical check does not establish native macOS app typechecking or live Netdata acceptance. Parent PR #7's exact old-head CI is terminal failure: macOS shard 0 failed this gate, shard 1 and Linux jobs passed. The child’s hosted run 37076620634 passed lint, Linux x64/ARM64, both macOS shards and aggregate CI on this exact head; musl was skipped. Original native pending input, live/private route acceptance, NETDATA-CLIENT-01 P2 and NETDATA-DOC-01 P3 retain their existing dispositions. No workflow, runtime, provider-control or locale changes.
Contributors:
718b02d7-0d4b-4670-b05f-57a5db28178d; source objective./root; native T3 UUID unavailable in the bound context./root/portfolio_slot_14, isolatednetdata-architecture-anchors-20261002-slot14worktree; exact coordinate correction, verification and publication.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Delivery coordination: M Jones authorized merging the complete #2 → #4 → #5 → #6 → #7 → #8 chain on October 7, 2026. Resume NetData Menu Bar Monitoring (
718b02d7-0d4b-4670-b05f-57a5db28178d) coordinates child-into-parent merges with current-head checks. Native live endpoint/polling/render acceptance remains separate.