Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore image and PDF preview controls from original PRs #52 and #58 on the accepted nightly line. Images retain dialog behavior and receive panel-only controls; PDFs load a local PDF.js viewer lazily with 60–800% zoom, search and retry. HTML retains its opaque-origin sandbox.
Pins pdfjs-dist to 6.3.289. Primary interactive preview acceptance remains with the integration coordinator.
Validation: all 22 focused preview tests, targeted lint and web typecheck passed. The production web build passed; the lazy viewer chunk contains all 186 expected CMap/font/WASM asset mappings, and emitted worker/WASM bytes match the pinned package. Hosted full CI is pending. Two exact-optional-property type mismatches were corrected during qualification.
Implemented by GPT-6 Astra through the Codex harness.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.