Repository navigation
test(codex): preserve strict legacy goal replay [L16 repair] - #130
Merged
Mjones13 merged 1 commit intoOct 5, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy replay transcripts predate the native goal API, so Stop's new goal read caused strict outbound-frame mismatches. The shared replay factory now supplies a null goal only when the entire transcript lacks goal-read/write capability; recorded goal traffic and all unexpected writes remain strict.
Fix-only child of #103 at 355900c. Preserves the three regression cases covering legacy/recorded terminal delivery and rejection of an unrecorded goal mutation. Original branch ownership stays unchanged; root must propagate the accepted repair into #105.
Validation: exact child adapter tests, scoped formatting/lint, server typecheck and normal commit hooks; full hosted CI on this non-draft child.
Prepared previously with GPT-6 Astra; resumed and published with GPT-6.1-Sol through Codex in T3 Code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.