Repository navigation
Add support for new objectStorageBucket field for USS config. - #2455
Closed
mfordkeeper wants to merge 15 commits into
Closed
mfordkeeper wants to merge 15 commits into
mfordkeeper wants to merge 15 commits into
Conversation
…or the results, parsing them before displaying a dialog for the actual sync
* MM-11 download membership timeout error * MM-11 download membership timeout error * MM-11 Fixed the args sequence in the methods * MM-11 Fixed the args sequence in the methods * MM-11 refactored and optimized the code for easy debugging
…ip (#2436) * MM-11 written test cases for the functionality * MM-11 Worked on test case review * MM-11 fixed linting issues
* MM-18-Added Created Users Functionality in Cyberark PAM import * MM-18 worked on review comments * MM-18 made delay as global constant * MM-18 rewrote the test cases with all edge case included * Removed Check existing users * MM-18 refactor changes * MM-18 worked on review comments * MM-18 worked on review comments * MM-18 added case insensitive comments * MM-18 rewrote the test cases
* Fix Service Mode filesystem bypasses * Add github actions for running windows unit-tests * Fix windows test cases failing * Fix claude review comments * Fix failing test case in windows * Fix failing test cases * Undo test case changes
The ADD_IDENTITY handler called EllipticCurvePublicNumbers.from_encoded_point(), which cryptography removed in 39.0.0, and built the ECDSA public key blob without the RFC 5656 curve-name string. Use EllipticCurvePublicKey.from_encoded_point() and include the curve name so ssh-add and SSH clients accept the key. After implementing the changes, i tested the full process using an ECDSA key and confirmed the change resolved the issue.
* MM-24 pagination offset and nextlink url fix * MM-24/worked on review comments * MM-24 redefined the resolve hosts * MM-24 Added batch fix * MM-24 worked on review comments * MM-24 added fetch to resolve next link properly
Process Notification Center data from sync-down and add the "notification" command (list, view, read, unread, approve, deny). Approve and deny handle device approvals, share requests and PAM workflow access requests. Notification types the client does not support (SUPPORTED_TYPES), such as EPM approval requests, are dropped on sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: Add Tailscale support for tunneling in Commander Service - Introduced Tailscale configuration and management in the service. - Added functions for installing, starting, and managing Tailscale daemons and funnels. - Enhanced ProcessInfo to track Tailscale status and ports. - Updated ServiceManager to handle Tailscale alongside existing tunneling options (ngrok, Cloudflare). - Implemented validation for Tailscale configuration parameters. - Created a new TailscaleConfigurator class for managing Tailscale setup and validation. - Added logging for Tailscale subprocess activities. - Updated unit tests to cover new Tailscale functionality. * feat: Update Windows Tailscale installation to use official MSI installer * feat: Enhance Windows Tailscale installation to update process PATH immediately * feat: Implement elevated installation for Tailscale on Windows using UAC prompt * Add support for Tailscale advertise tags in service configuration - Introduced `tailscale_advertise_tags` to ServiceConfig and related classes. - Updated ServiceConfigHandler to handle new argument for Tailscale. - Modified TailscaleConfigurator to utilize advertise tags during authentication. - Adjusted validation logic to check for presence of Tailscale auth key and tags. - Enhanced installation and daemon management functions to ensure proper handling of Tailscale. - Updated unit tests to cover new `tailscale_advertise_tags` parameter. * feat: Add Tailscale Funnel support to service configuration and commands * chore: Remove obsolete Tailscale subprocess log file * feat: Add Tailscale support for tunneling in Commander Service - Introduced Tailscale configuration and management in the service. - Added functions for installing, starting, and managing Tailscale daemons and funnels. - Enhanced ProcessInfo to track Tailscale status and ports. - Updated ServiceManager to handle Tailscale alongside existing tunneling options (ngrok, Cloudflare). - Implemented validation for Tailscale configuration parameters. - Created a new TailscaleConfigurator class for managing Tailscale setup and validation. - Added logging for Tailscale subprocess activities. - Updated unit tests to cover new Tailscale functionality. * feat: Implement elevated installation for Tailscale on Windows using UAC prompt * Add support for Tailscale advertise tags in service configuration - Introduced `tailscale_advertise_tags` to ServiceConfig and related classes. - Updated ServiceConfigHandler to handle new argument for Tailscale. - Modified TailscaleConfigurator to utilize advertise tags during authentication. - Adjusted validation logic to check for presence of Tailscale auth key and tags. - Enhanced installation and daemon management functions to ensure proper handling of Tailscale. - Updated unit tests to cover new `tailscale_advertise_tags` parameter. * feat: Validate Tailscale Funnel port in start_tailscale_funnel function * feat: Enhance Tailscale Funnel management during service startup and status checks * feat: Implement Tailscale Funnel activation verification and rollback in configuration * chore: Remove obsolete Tailscale subprocess log file * fix : tailscale auto installation with service-crete fixes for sudo permissions as tailscale runs on root * chore: Remove Tailscale subprocess log from tracking and gitignore it This runtime log has been accidentally re-committed multiple times because no .gitignore rule ever persisted for it. Adding the rule this time so it can't creep back in on a future commit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * feat: Add Tailscale support as a sidecar for service tunneling and configuration * fix: Enhance Tailscale sidecar configuration with explicit container naming and argument handling * feat: Enhance Tailscale integration and improve error handling - Refactor DockerComposeBuilder to add Tailscale as a sidecar with improved handling of environment variables and health checks. - Update setup_base.py to securely prompt for Tailscale auth key using getpass. - Modify tunneling.py to improve Tailscale installation and management, including enhanced error handling for installation failures and signature verification for Windows MSI. - Add unit tests for Tailscale integration, ensuring correct behavior of service URL resolution and metadata writing. - Implement checks for Tailscale Funnel status, ensuring proper teardown and avoiding unnecessary resets. - Improve service management to handle Tailscale-related failures gracefully, maintaining state integrity during errors. * feat: Update Tailscale Funnel configuration and logging in Docker setup * feat: Update Tailscale auth key input method to allow pasting * feat: Add support for unattended mode in Tailscale on Windows and enhance daemon status checks * refactor: Remove unnecessary checks for Tailscale daemon state in is_tailscale_daemon_running function * feat: Enhance Tailscale Funnel URL handling and improve diagnostics in Docker setup * fix: addressed review comments
* Surface reporting permission failures early and clearly * Fix claude review comments
Contributor
Author
|
Replaced by #2469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #2373