Repository navigation
Macos enable all tests - #1073
Merged
Merged
Conversation
When the layer returns the simulated extension list, it decided whether to append the emulated VK_KHR_portability_subset by checking both the simulated and the real device extensions. On a device that natively supports the extension, like MoltenVK, the emulated extension was never appended even though the returned list did not contain it. Check only the list that was actually returned: the simulated extensions when simulating, the real ones otherwise.
The tests were disabled on macOS for the C.I. setup without a recorded reason. The Python tests were excluded for jsonschema loading issues that no longer occur. All of them now pass on macOS with MoltenVK except test_api_create_device: the VP_LUNARG_minimum_requirements checks fail on devices without wideLines that report a lineWidthGranularity of 0.
Collaborator
|
CI VulkanProfiles build # 4702 running. |
1 similar comment
Collaborator
|
CI VulkanProfiles build # 4702 running. |
Collaborator
|
CI VulkanProfiles build # 4702 failed. |
The required lineWidthRange, lineWidthGranularity, pointSizeRange and pointSizeGranularity limits depend on the wideLines and largePoints features. Without these features, devices such as MoltenVK report a granularity of 0, which failed the VP_LUNARG_minimum_requirements isMultiple(1.0, lineWidthGranularity) check. The library generator does not use VulkanObject and its property requirement depends yet, so add a hard-coded table of these limits and the feature they depend on as a workaround. The property comparators now receive the device features and only check these limits when the feature is supported.
Collaborator
|
CI VulkanProfiles build queued with queue ID 176710. |
1 similar comment
Collaborator
|
CI VulkanProfiles build queued with queue ID 176710. |
Collaborator
|
CI VulkanProfiles build # 4703 running. |
Collaborator
|
CI VulkanProfiles build # 4703 passed. |
ansaryrahman9-cpu
approved these changes
Oct 30, 2026
ansaryrahman9-cpu
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.