Repository navigation
build: Only rerun profiles generation when its inputs change - #1079
Merged
Merged
Conversation
The vkprofiles generation steps were custom targets without outputs, so every build reran them and rewrote the generated headers and sources, recompiling and relinking all the tests. - Use custom commands with OUTPUT and DEPENDS for the profiles graph, the test graph, the test library, the layer and layer tests sources, the combine test profiles and the Android profiles transform. - Run the generated requirements steps as a single vkprofiles graph execution instead of 27 vkprofiles processes. - Only rewrite baked_version.py when its content changes, and only create the generated library placeholders when missing, so reconfiguring doesn't trigger a PyInstaller rebuild and a full recompile. On macOS with BUILD_TESTS=ON, a no-op build goes from 55s to 1s and a cold build from 72s to 33s.
Collaborator
|
CI VulkanProfiles build queued with queue ID 178761. |
1 similar comment
Collaborator
|
CI VulkanProfiles build queued with queue ID 178761. |
Collaborator
|
CI VulkanProfiles build # 4717 running. |
Collaborator
|
CI VulkanProfiles build # 4717 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vkprofiles generation steps were custom targets without outputs, so every build reran them and rewrote the generated headers and sources, recompiling and relinking all the tests.
On macOS with BUILD_TESTS=ON, a no-op build goes from 55s to 1s and a cold build from 72s to 33s.