Skip to content

feat(config): accept autofix settings in project manifests - #320

Draft
marckong wants to merge 2 commits into
mainfrom
marckong/manifest-autofix
Draft

marckong wants to merge 2 commits into
mainfrom
marckong/manifest-autofix

Conversation

@marckong

Copy link
Copy Markdown
Contributor

Tracking

None. Follow-up to the OpenAPI sync in #51, whose AI review flagged this (client.gen.go:8598).

Why

The synced contract adds autofix to ProjectConfig, so volcano config pull can export an autofix: section. Manifest decodes with KnownFields(true) and has no such field, so the CLI could not load its own pulled manifest.

Summary

  • Add AutofixManifest (enabled, auto_trigger, max_stage, model, provider) to Manifest. Nil fields preserve current values; enum values stay server-validated.
  • The API key is deliberately not a manifest field.
  • Document the section in docs/project-configuration.md.

Verification

  • go test ./internal/projectconfig/ ./internal/cmd/config/ ./internal/docs/... pass, including new round-trip, omitted-vs-explicit-false, and api_key-rejected cases.
  • go vet and gofmt clean. Full make check and the docs lint were not run locally.

🤖 Generated with Claude Code

The synced API contract adds an autofix section to the project config
export. The manifest loader rejects unknown fields, so a pulled manifest
containing autofix would fail to load. Add the section so it round-trips.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

…ntract

Cloud HOBBY sandboxes accept 1024 MiB and 30-3600 second sessions, and the
domain-verification TXT value is stable only until Volcano rotates its key.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants