Repository navigation
feat(player): add reverse playback and fix device/decoder issues #117
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -168,7 +168,7 @@ MA_API ma_device_config* sf_allocate_device_config(const ma_device_type deviceTy | |
|
|
||
| // Allocate memory for a decoder configuration struct. | ||
| MA_API ma_decoder_config *sf_allocate_decoder_config(const ma_format outputFormat, const ma_uint32 outputChannels, | ||
| const ma_uint32 outputSampleRate, const ma_uint32 seekPointCount) { | ||
| ma_decoder_config *pConfig = sf_create(ma_decoder_config); | ||
| if (pConfig == NULL) { | ||
| return NULL; | ||
|
|
@@ -177,6 +177,8 @@ MA_API ma_decoder_config *sf_allocate_decoder_config(const ma_format outputForma | |
| MA_ZERO_OBJECT(pConfig); | ||
| *pConfig = ma_decoder_config_init(outputFormat, outputChannels, outputSampleRate); | ||
|
|
||
| pConfig->seekPointCount = seekPointCount; | ||
|
There was a problem hiding this comment.
The native function now accepts Knowledge Base Used: Audio devices and MiniAudio backend Prompt To Fix With AIThis is a comment left during a code review.
Path: Native/miniaudio-backend/library.c
Line: 180
Comment:
**Seek settings differ by platform**
The native function now accepts `seekPointCount`, but the packaged Android, Intel macOS, and FreeBSD libraries were not updated. Those unchanged libraries still use the previous implementation, which does not apply the fourth argument. Rebuild the remaining runtime assets so users on those platforms also get the new seek-point setting.
**Knowledge Base Used:** [Audio devices and MiniAudio backend](https://app.greptile.com/lsxprime/-/custom-context/knowledge-base/lsxprime/soundflow/-/docs/audio-device-backend.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Owner
Author
There was a problem hiding this comment. Holy fuck, I actually built the native libraries and forgot to replace them in the It’s not that I’m too lazy to do another There was a problem hiding this comment. You're right—the release workflow rebuilds the native libraries for all RIDs, replaces Tip: You can customize Greptile's behavior for this repo with |
||
|
|
||
| return pConfig; | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,12 +27,21 @@ public sealed class FullDuplexDevice : AudioDevice, IDisposable | |
| public Mixer MasterMixer => PlaybackDevice.MasterMixer; | ||
|
|
||
| /// <summary> | ||
| /// Occurs when audio data is processed by either the capture or playback device. | ||
| /// Subscribers will receive both near-end (capture) and far-end (playback) frames. | ||
| /// </summary> | ||
| public new event AudioProcessCallback? OnAudioProcessed | ||
|
There was a problem hiding this comment.
Knowledge Base Used: Audio devices and MiniAudio backend Prompt To Fix With AIThis is a comment left during a code review.
Path: Src/Abstracts/Devices/FullDuplexDevice.cs
Line: 33
Comment:
**Full-duplex callbacks disappear**
`FullDuplexDevice` hides the new base event with `new`, so subscribing through an `AudioDevice` reference attaches to a separate event that never fires. For example, `AudioDevice device = fullDuplexDevice; device.OnAudioProcessed += handler;` receives neither capture nor playback samples. Make the base event overridable and override its accessors, or forward both child events into the base event.
**Knowledge Base Used:** [Audio devices and MiniAudio backend](https://app.greptile.com/lsxprime/-/custom-context/knowledge-base/lsxprime/soundflow/-/docs/audio-device-backend.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. |
||
| { | ||
| add | ||
| { | ||
| CaptureDevice.OnAudioProcessed += value; | ||
| PlaybackDevice.OnAudioProcessed += value; | ||
|
Comment on lines
+33
to
+38
There was a problem hiding this comment. 9. Base-typed duplex listeners hear nothing FullDuplexDevice hides the new base OnAudioProcessed event with a separate forwarding event instead of overriding subscription behavior. A listener holding the duplex device as AudioDevice subscribes to its never-raised base event, rather than either child device's capture or playback event. Agent Prompt
|
||
| } | ||
| remove | ||
| { | ||
| CaptureDevice.OnAudioProcessed -= value; | ||
| PlaybackDevice.OnAudioProcessed -= value; | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
|
|
@@ -87,4 +96,12 @@ public override void Dispose() | |
|
|
||
| IsDisposed = true; | ||
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| internal override Delegate[] GetEventSubscribers() | ||
| { | ||
| // Subscribers are routed to the child devices, so we retrieve them from there. | ||
| // Returning CaptureDevice's list is sufficient as both will have the same subscribers. | ||
| return CaptureDevice.GetEventSubscribers(); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12. Future codec releases keep an old version
🐞 Bug⚙ MaintainabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools