Skip to content

[test] Cover top-up maximum balance validation #1799

Closed

Description

@K1NGD4VID

Labels: testing, frontend, points: 150
File/location: frontend/src/components/stream-creation/TopUpModal.tsx

Description:
Insufficient balance, maximum amount, and token mismatch paths lack tests.

Acceptance Criteria:

  • Add deterministic tests for the documented success and failure paths, including boundary inputs and dependency failures.
  • Run the new tests in the corresponding CI suite and assert the public behavior and error contract.

Notes:
This is a focused regression gap for the cited module; it was not covered by the existing test files reviewed during the sweep.

Activity

  1. byteMara commented on Oct 22, 2026

    @byteMara

    @byteMara has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I investigated the affected functionality and understand the changes needed to achieve the expected result. I can take this issue and ensure the implementation is reliable.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @byteMara to this issue.

  2. MaybeSomeone-arc18 commented on Oct 22, 2026

    @MaybeSomeone-arc18

    @MaybeSomeone-arc18 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I'd like to take this. Plan: table-driven tests covering the top-up max-balance boundary - exact limit, one over, cumulative top-ups crossing the cap, and the surfaced error - wired into the repo's existing test setup. I ship tested code - recent Liquifact Stellar frontend PRs (3 open, CI green). Can open a PR within 24h of assignment.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @MaybeSomeone-arc18 to this issue.

  3. aigbagbobila commented on Oct 22, 2026

    @aigbagbobila

    @aigbagbobila has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer can I resolve this please assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @aigbagbobila to this issue.

  4. drips-wave commented on Oct 22, 2026

    @drips-wave

    Congratulations, @aigbagbobila! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @aigbagbobila: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  5. grantfox-oss commented on Oct 22, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @aigbagbobila's PR #1804 was approved and merged by @K1NGD4VID.

    🏆 @aigbagbobila: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,145 total points). Track your full progress on GrantFox.

    👏 Great work, @aigbagbobila! Keep contributing to LabsCrypt.

  6. drips-wave commented on Oct 22, 2026

    @drips-wave

    This issue has been completed by @aigbagbobila as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @aigbagbobila: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programfrontendFrontend related taskspoints: 150testingTesting related tasks

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions