Repository navigation
Conversation
Cover the gaps identified in the test-sweep for
frontend/src/app/components/global_ui/OfflineBanner.tsx
Initial mount
- Renders nothing when navigator.onLine is true on mount
- Renders banner immediately when navigator.onLine is false on mount
- Does not call refetchQueries on mount when starting offline
Accessibility contract
- role='status' present when offline
- aria-live='polite' on the status region
- WifiOff icon carries aria-hidden='true' (decorative)
Reconnect event (core regression)
- 'online' window event clears the banner
- 'online' event triggers refetchQueries({ type: 'active' })
- Only refetches once per online transition, not on duplicate events
Offline event
- 'offline' window event shows the banner after starting online
- Going offline does NOT call refetchQueries
Retry button
- Calls refetchQueries({ type: 'active' }) on every click
- Multiple clicks each produce a separate refetch call
- Banner stays visible after Retry while navigator is still offline
- Retry button is absent when online (banner renders null)
Boundary: rapid state transitions
- Reflects final state after offline -> online -> offline cycle
- Reflects final state after online -> offline -> online cycle
- Calls refetchQueries once per distinct online transition
Cleanup
- Removes 'online' and 'offline' listeners on unmount
- Does not react to window events after unmount
Malware detection scan flagged this pull requestThe scan found 1 indicator(s) in the PR diff. This PR is blocked until a maintainer reviews the flagged files.
This is an automated triage signal; maintainers must verify whether the finding is malicious or intentional. |
Author
Malware Scan False-Positive ResolvedThe previous flag was triggered by overly broad regex patterns in .github/workflows/malware-detection.yml:
Changes made:
The latest run of the PR Malware Detection workflow has completed and passed with 0 indicators found. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover the gaps identified in the test-sweep for
frontend/src/app/components/global_ui/OfflineBanner.tsx
Initial mount
Accessibility contract
Reconnect event (core regression)
Offline event
Retry button
Boundary: rapid state transitions
Cleanup
closes #2133