Repository navigation
chore: upgrade/php-8.3.36 - #31
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The narrowed PHP compatibility range needs correction, and the new Docker/CI environment still needs runtime validation before approval.
1 open issue
What changed in this PR
Updates the library’s PHP baseline to 8.3.36 and adds a Docker-based test environment.
Changes:
- Updates Composer requirements and CI runtime setup.
- Adds Docker testing with MySQL, optional custom CA support, and Xdebug coverage.
- Makes nullable insert-ID parameters explicit across the manager and adapter API.
| File | Description |
|---|---|
src/DatabaseManager.php |
Makes the insert-ID name parameter explicitly nullable. |
src/Adapter/PdoAdapter.php |
Aligns the PDO implementation’s nullable parameter. |
src/Adapter/AdapterInterface.php |
Updates the matching interface declaration. |
README.md |
Documents Docker tests, certificates, cleanup, and coverage. |
Dockerfile |
Adds the PHP test image with Composer and Xdebug. |
composer.json |
Changes the supported PHP version range. |
compose.yaml |
Configures tests, MySQL, coverage storage, and CA secrets. |
.gitignore |
Excludes generated coverage reports. |
.github/workflows/php.yml |
Configures PHP 8.3.36 and updates the cache action. |
.dockerignore |
Excludes dependencies, coverage, and repository metadata. |
Review effort: Balanced
ddurandg
previously approved these changes
Oct 22, 2026
lhbarrientosz
force-pushed
the
upgrade/php-8.3.36
branch
from
October 22, 2026 20:03
f8aed73 to
e85edec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Current branch unit test coverage
PHP Compatibility and Security Validation
This PR upgrades the project's baseline to PHP 8.3.36 and updates the development tooling to support it.
The library was tested using official PHP Docker images with the following results:
Tests were executed with all PHP error levels enabled (
E_ALL). No warnings, deprecations, or risky tests were observed.The following checks also passed on PHP 8.3.36:
Security Considerations
These PHP releases include fixes for:
Composer constraint:
{ "php": "~8.3.36 || ~8.4.27 }