Repository navigation
Conversation
t-8ch
reviewed
Oct 13, 2026
d4nuu8
force-pushed
the
feature/btrfs-mount-options
branch
from
October 13, 2026 13:17
fc8f691 to
2b0578e
Compare
d4nuu8
changed the title
t-8ch
reviewed
Oct 13, 2026
t-8ch
left a comment
t-8ch
left a comment
Collaborator
There was a problem hiding this comment.
Nice! A few more comments.
Populate Btrfs with mkfs.btrfs -r --compress to avoid exhausting partitions sized for compressed data. Derive the compression algorithm and level from mount options while preserving explicit mkfs overrides. Add regression tests for this behavior. Signed-off-by: Daniel Braunwarth <daniel.braunwarth@kuka.com>
d4nuu8
force-pushed
the
feature/btrfs-mount-options
branch
from
October 13, 2026 13:53
2b0578e to
6e121fe
Compare
t-8ch
reviewed
Oct 13, 2026
Collaborator
|
I am testing this now and will push it after. I am wondering if we should always use the highest compression here automatically. |
Contributor
Author
I would stick to the default level. |
Collaborator
Ack. |
Collaborator
|
Picked up manually, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate Btrfs with mkfs.btrfs -r --compress to avoid exhausting partitions
sized for compressed data.
Derive the compression algorithm and level from mount options while
preserving explicit mkfs overrides. Add regression tests for this behavior.