Repository navigation
Update all DB methods to always compare referenced entities by FK - #1153
Open
Toastbrot236 wants to merge 2 commits into
Open
Toastbrot236 wants to merge 2 commits into
Toastbrot236 wants to merge 2 commits into
Conversation
…erence (except grief reports)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I no longer want to constantly deal with issues where Refresh will fail to fetch entities from DB due to comparing entities referenced by them by object reference instead of just comparing the foreign keys themselves, since that will usually fail if the referenced entity isn't included explicitly. Also updates comment deletion methods to try and manually fetch the level or user the comment was posted on if their object reference is null on the given comment.
Hopefully I got all DB queries which do such a thing. I excluded grief reports from this because they generally need fixes and tweaks everywhere, which I'd rather do in a separate PR.