Repository navigation
feat(network): add option to disable DSCP tagging - #6067
Merged
Merged
Conversation
2 tasks done
ReenigneArcher
approved these changes
Nov 8, 2026
Some consumer routers mishandle DSCP-tagged traffic, causing audio loss on Wi-Fi. Allow disabling tagging regardless of client request.
ReenigneArcher
force-pushed
the
feat/dscp-tagging-option
branch
from
November 9, 2026 00:05
cd1adb6 to
da32f3c
Compare
|
Bundle ReportChanges will increase total bundle size by 456 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6067 +/- ##
=========================================
Coverage 49.35% 49.36%
=========================================
Files 143 143
Lines 31300 31302 +2
Branches 13347 13354 +7
=========================================
+ Hits 15449 15452 +3
- Misses 12235 13419 +1184
+ Partials 3616 2431 -1185
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #6067 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: AppImage-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
dscp_taggingoption (Network tab, enabled by default) to turn off DSCP tagging for audio and video regardless of what the client requests.With a Linux host, tagged audio can cause episodic loss on some consumer routers (TP-Link so far), heard as crackling on any client. Thanks to @Catkinsv3 for tracking this down in #5508. Until now the only workaround was an iptables mangle rule.
This covers the audio and video sockets. The control stream keeps its own DSCP tag. Local priority (
SO_PRIORITYon Linux) is not affected, but on Windows there's no prioritization without tagging, so qWAVE is skipped entirely when disabled.Kept it as a simple toggle instead of per-type values, since disabling is what actually fixes the issue. Can extend it if needed.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Built on Linux (gcc 16, Release, CUDA off).
test_sunshine: 905 passed, 8 skipped, including the newConfigPersistenceTest.ParsesDscpTaggingOptionvitest: 213 passed, including a new test toggling the checkbox on the Network tabclang-formatpassessetsockoptcalls:IP_TOSis set on the video and audio sockets when enabled and not set when disabled,SO_PRIORITYis unchangedWindows and macOS were not built locally.
Type of Change
Checklist
AI Usage
See our AI usage policy.