Skip to content

Don't re-evaluate glucose alerts from a backfill older than the last reading #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ps2 wants to merge 1 commit into from
Closed

Don't re-evaluate glucose alerts from a backfill older than the last reading #2521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Loop/Managers/Alerts/GlucoseAlertManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,13 @@ final class GlucoseAlertManager: ObservableObject {
os_log("Skipping stale sample", log: log, type: .debug)
return
}
// CGMs deliver the live reading and then backfill. A batch whose newest
// sample is no newer than the one already evaluated must not re-decide
// — and in particular must not retract — the alert that reading raised.
if let evaluated = latestReading, latest.date <= evaluated.date {
os_log("Skipping batch older than the latest evaluated reading", log: log, type: .debug)
return
}
latestReading = (latest.quantity.doubleValue(for: .milligramsPerDeciliter), latest.date)
let config = activeConfiguration(at: now)
let mgdl: Double
Expand Down