Skip to content

fix(ci): normalize CRLF line endings in checksum verification #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ClausValcaTD merged 1 commit into from
Oct 9, 2026
Merged

fix(ci): normalize CRLF line endings in checksum verification #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Flatpak.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Clone OpenROM binaries repo
run: |
git clone --depth 1 https://github.com/M5Devs/OpenROM-bins.git bins
(cd bins && sha256sum -c checksums.sha256)
(cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -)

- name: Set up Flutter
uses: subosito/flutter-action@v2
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/Release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
shell: bash
run: |
git clone https://github.com/M5Devs/OpenROM-bins.git bins
(cd bins && sha256sum -c checksums.sha256)
(cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -)

- name: Copy Windows binaries
run: |
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
- name: Fetch binaries from OpenROM-bins
run: |
git clone https://github.com/M5Devs/OpenROM-bins.git bins
(cd bins && sha256sum -c checksums.sha256)
(cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -)
mkdir -p assets/linux/x86_64
cp -r bins/linux/x86_64/. assets/linux/x86_64/
chmod +x assets/linux/x86_64/*
Expand Down Expand Up @@ -277,7 +277,7 @@ jobs:
- name: Fetch binaries from OpenROM-bins
run: |
git clone https://github.com/M5Devs/OpenROM-bins.git bins
(cd bins && sha256sum -c checksums.sha256)
(cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -)
mkdir -p assets/linux/arm64
cp -r bins/linux/arm64/. assets/linux/arm64/
chmod +x assets/linux/arm64/*
Expand Down Expand Up @@ -384,7 +384,7 @@ jobs:
- name: Fetch binaries from OpenROM-bins
run: |
git clone https://github.com/M5Devs/OpenROM-bins.git bins
(cd bins && (sha256sum -c checksums.sha256 || shasum -a 256 -c checksums.sha256))
(cd bins && (tr -d '\r' < checksums.sha256 | sha256sum -c - || tr -d '\r' < checksums.sha256 | shasum -a 256 -c -))
mkdir -p assets/macos/arm64 assets/macos/x86_64
cp -r bins/macos/arm64/. assets/macos/arm64/
cp -r bins/macos/x86_64/. assets/macos/x86_64/
Expand Down
2 changes: 1 addition & 1 deletion build_linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -e

if [ -d "bins" ]; then
echo "=== Verifying OpenROM-bins checksums ==="
(cd bins && sha256sum -c checksums.sha256)
(cd bins && tr -d '\r' < checksums.sha256 | sha256sum -c -)
fi

echo "=== Building OpenROM Core (Dart CLI) ==="
Expand Down
2 changes: 1 addition & 1 deletion build_mac.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -e

if [ -d "bins" ]; then
echo "=== Verifying OpenROM-bins checksums ==="
(cd bins && (sha256sum -c checksums.sha256 || shasum -a 256 -c checksums.sha256))
(cd bins && (tr -d '\r' < checksums.sha256 | sha256sum -c - || tr -d '\r' < checksums.sha256 | shasum -a 256 -c -))
fi

echo "=== Building OpenROM Core (Dart CLI) ==="
Expand Down
Loading