Repository navigation
API and integrations: webhook rotation, auth contract tests, GHES config, token expiry diagnostics - #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1239
Closes #1242
Closes #1245
Closes #1246
Summary
WebhookSignatureRotationsigns with the current secret and still accepts the previous one for a configurable grace window (default 24h). Docs indocs/WEBHOOK_SIGNATURE_ROTATION.md.error,message,timestamp) forJwtAuthGuardandRolesGuard, and check that no credentials leak.baseUrlonGitHubAuthConfig, normalized to<host>/api/v3. https only. Defaults to github.com, so existing configs are unchanged.diagnoseTokenExpirationandGitHubClient.getTokenExpiration()classify a token asno_expiry,valid,expiring_soon,expiredorinvalid.Testing
New specs cover success, boundary, invalid-input and failure cases (38 tests, all passing locally).
🤖 Generated with Claude Code