Fix isoform accession handling + examples - #215
Merged
Merged
Conversation
cpadillafranzotti
commented
Sep 15, 2026
- Fixed the regex in resolveProteinIds() to accept an optional isoform suffix, with proper anchoring
- Added new examples
- Note: InterPro and UniProtKB's own APIs don't support isoform-specific queries, so those two tracks will remain empty for isoform accessions regardless of this fix.
Author
|
Hi @EliotRagueneau I made the changes I mentioned to you yesterday, it's now working with isoforms. Could you review it when you get a moment? The last example is the MAPT protein (EBI-21196290), you can check it out on the demo. |
EliotRagueneau
marked this pull request as ready for review
September 16, 2026 13:33
|
Looks good to me :D |
Author
|
Thanks for reviewing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.