Repository navigation
Fix: Ensure ldapEmailField is formatted as a JSON array - #484
Open
TrinityBerserker wants to merge 2 commits into
Open
TrinityBerserker wants to merge 2 commits into
TrinityBerserker wants to merge 2 commits into
Conversation
righel
reviewed
Oct 27, 2026
| \"ldapDefaultOrg\": \"${APACHESECUREAUTH_LDAP_DEFAULT_ORG}\", | ||
| \"ldapAllowReferrals\": ${APACHESECUREAUTH_LDAP_OPT_REFERRALS}, | ||
| \"ldapEmailField\": ${APACHESECUREAUTH_LDAP_EMAIL_FIELD} | ||
| \"ldapEmailField": [\"${LDAPAUTH_LDAPEMAILFIELD}\"], |
Contributor
There was a problem hiding this comment.
Missing backslash escaping the ldapEmailField last double quote
ostefano
requested changes
Oct 27, 2026
ostefano
left a comment
ostefano
left a comment
Collaborator
There was a problem hiding this comment.
This is wrong. the field is APACHESECUREAUTH_LDAP_EMAIL_FIELD but you are using the LDAPAUTH_LDAPEMAILFIELD env var.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the JSON generation for ldapEmailField in configure_misp.sh. The value was being processed as a raw string, but the LdapAuth plugin expects an array. The fix wraps the value in brackets and quotes to ensure a valid JSON array is generated.
Verification:
I tested this locally by running the Docker setup with LDAPAUTH_ENABLE=true and LDAPAUTH_LDAPEMAILFIELD="mail". The previous error Provided new config is not array, NULL given no longer appears in the logs, and the configuration is generated correctly.
Fixes #287