Repository navigation
Add binGraph expansion module for attachments and malware samples - #1011
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add local binary visualizations for
attachmentandmalware-sampleattributes, inspired by geekscrapy/binGraph. Enrichment returns an entropy plot and byte histogram as a PNG in the existing MISPimageobject, with avisualizesreference to the source attribute. No new object template is required.infected, verify the unpacked MD5, and enforce input and decompression limits. Samples are processed in memory without execution or extraction to disk.to_ids=falsewith correlation disabled. Use the headless Agg canvas and serialize rendering across concurrent requests.Validation:
python -m pytest -q tests/test_bingraph.py— 40 passed. Black, isort, flake8 andgit diff --checkpass. The published tree matches the validated local tree.This implementation treats inputs as binary blobs and does not include PE/ELF section or entry-point annotations. It reports entropy in bits per byte (0–8) and uses a minimum 256-byte window. Live MISP UI integration remains untested; PyMISP image-object import and source references are covered by the tests.