Repository navigation
Release 0.20.2: start calls name an address only when requested (PFL-769) - #46
Merged
Merged
Conversation
…769) Email link, OTP resend, passkey sign-up and forgot password sent the app's default redirect as if it had been requested. The server validates what it is sent, and an app need not list the server's default, so those starts failed on such an app. They now send only a requested address and the server picks otherwise. The forgot-password success screen no longer requires one, and a tab waiting on its link applies the app's default at the end. Co-Authored-By: Magus <magus@madappgang.com> Crafted with agentic harness Magus (https://github.com/MadAppGang/magus) Claude-Session: https://claude.ai/code/session_012wctgs8R7pfHS6Hp7aZ4KN
Co-Authored-By: Magus <magus@madappgang.com> Crafted with agentic harness Magus (https://github.com/MadAppGang/magus) Claude-Session: https://claude.ai/code/session_012wctgs8R7pfHS6Hp7aZ4KN
The screen starts its request on mount, so its ending held the sign-in path from before the flow registered it, and the real page looked like another address. Co-Authored-By: Magus <magus@madappgang.com> Crafted with agentic harness Magus (https://github.com/MadAppGang/magus) Claude-Session: https://claude.ai/code/session_012wctgs8R7pfHS6Hp7aZ4KN
A redirect_url left on the sign-in or forgot-password page URL is no longer carried into the attempt, and useSignInEnding reads the latest navigate as well as the latest sign-in path. The changelog states where each ending goes with no target. Co-Authored-By: Magus <magus@madappgang.com> Crafted with agentic harness Magus (https://github.com/MadAppGang/magus) Claude-Session: https://claude.ai/code/session_012wctgs8R7pfHS6Hp7aZ4KN
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
Co-Authored-By: Magus <magus@madappgang.com> Crafted with agentic harness Magus (https://github.com/MadAppGang/magus) Claude-Session: https://claude.ai/code/session_012wctgs8R7pfHS6Hp7aZ4KN
…-769) Reading the latest navigate changed what an opened link does with a path outside the flow, from a page load to a history push that a host with no router can't render. The ending goes back to the navigate of its own render, and only the sign-in path is read late. Tests now cover the page param on sign-up and forgot password too. Co-Authored-By: Magus <magus@madappgang.com> Crafted with agentic harness Magus (https://github.com/MadAppGang/magus) Claude-Session: https://claude.ai/code/session_012wctgs8R7pfHS6Hp7aZ4KN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release for PFL-769.
Changes
redirect_urlonly when the request gave one. They used to send the app's default, which failed on an app that doesn't list the server's default in its redirect URLs.redirect_url.redirect_urlleft on the sign-in, sign-up or forgot-password page isn't carried into the attempt.Behaviour change
With no target given, an email link, OTP or password reset ends where the server's answer says: the app's first registered redirect URL, or the server's default if the app has none. Put the URL you want first in the list. This changes the ending for an app that lists the server's default with another URL ahead of it: users now go to that first URL.
Testing
Crafted with agentic harness Magus (https://github.com/MadAppGang/magus)
https://claude.ai/code/session_012wctgs8R7pfHS6Hp7aZ4KN