Repository navigation
Trajectory viewer: load the exact .mjs, not the whole session folder - #575
Merged
Merged
Conversation
The viewer kept only the .mjs's directory and then globbed session_poses.mrp, scan_lio_*.laz and trajectory_lio_*.csv from it, so a folder holding two sessions loaded the wrong poses and mixed chunks. Poses now come from the manifest's poses_file_name (falling back to initial_poses_file_name) and chunks from its laz_file_names, with the same missing-path relocation as Session::load. --mjs, drag & drop and Ctrl+O (now a .mjs picker) keep the exact file; a directory still resolves to its session.mjs, or its only .mjs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The trajectory viewer kept only the directory of the
.mjsit was given, then picked files from that folder by fixed names and patterns:session_poses.mrp/session_ini_poses.mri, everyscan_lio_*.lazand everytrajectory_lio_*.csv. When a folder held two sessions, it loaded the wrong poses and/or mixed their chunks.Fix
poses_file_name; if that is missing or empty, frominitial_poses_file_name.laz_file_names, in manifest order.trajectory_lio_N.csvnext to its laz..mjs, the same ruleSession::loaduses.loadSession,loadCloudand the ROS export input all use this one helper.--mjs, dropping a.mjson the window, and the panel field (now "Session (.mjs)") keep the exact file. Ctrl+O is now a.mjsfile picker instead of a folder picker.session.mjs, or to its only.mjs; if there are several and none issession.mjs, the viewer shows an error. After loading, the field shows which.mjswas used.Testing
🤖 Generated with Claude Code