Repository navigation
Clone fewer submodules in CI - #585
Merged
Merged
Conversation
michalpelka
approved these changes
Oct 27, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #583.
15 of the last 40 failed CI runs failed while cloning Eigen from GitLab. Every workflow checked out submodules recursively, so each push cloned Eigen 14 times, including a nested copy in observation_equations' examples that HDMapping doesn't use.
libE57Format's googletest and observation_equations' example eigen/imgui, which
the build doesn't use)
This cuts GitLab clones per push from 14 to 6. Once there is a GitHub mirror of Eigen (e.g.
MapsHD/eigen), switching to it is a one-line.gitmoduleschange I'm happy to follow up with.Tested in a fresh clone with top-level submodules only: the Linux build, ctest and the Python bindings job pass.