Repository navigation
Statelessly track requested credentials via nonce - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens up credential presentation by tracking the expected shape of the presented credentials via the nonce. The doc type of a presented mdoc is verified, and SD-JWT-VCs verify which VCTs were noted as acceptable.
To keep things stateless, these extra signals are tracked via the nonce. This represents a breaking change as nonces generated before updating to this version of the library will not contain the necessary new values. But since no one's using the library right now that's fine. At worst they'll have to re-request the credential since requests are only good for five minutes by default.
(Note to future self: I will be much less cavalier about this if this project starts to see adoption.)